r79089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79088‎ | r79089 | r79090 >
Date:23:02, 27 December 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Comment out "subscribe to mediawiki-l" feature until we actually implement it. I'd really like to see this working, but we need to build some sort of API for Mailman.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
——@@ -597,11 +597,16 @@
598598 'label' => 'config-admin-email',
599599 'help' => $this->parent->getHelpBox( 'config-admin-email-help' )
600600 ) ) .
601 - $this->parent->getCheckBox( array(
 601+ /**
 602+ * Uncomment this feature once we've got some sort of API to mailman
 603+ * to handle these subscriptions. Some dummy wrapper script on the
 604+ * mailman box that shell's out to mailman/bin/add_members would do
 605+ $this->parent->getCheckBox( array(
602606 'var' => '_Subscribe',
603607 'label' => 'config-subscribe',
604608 'help' => $this->parent->getHelpBox( 'config-subscribe-help' )
605609 ) ) .
 610+ */
606611 $this->getFieldSetEnd() .
607612 $this->parent->getInfoBox( wfMsg( 'config-almost-done' ) ) .
608613 $this->parent->getRadioSet( array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r793731.17: MFT r78308, r78622, r79089, r79185, r79199, r79213, r79214, r79253catrope21:09, 31 December 2010
r79509Remove verification for help field hint for 'Subscribe to the release announ...nadeesha09:05, 3 January 2011
r79678* Validate e-mail address if provided...demon22:37, 5 January 2011

Comments

#Comment by 😂 (talk | contribs)   23:03, 27 December 2010

I meant mediawiki-announce.

#Comment by Happy-melon (talk | contribs)   11:24, 28 December 2010

Surely you just need to POST to https://lists.wikimedia.org/mailman/subscribe/mediawiki-announce with the email address?

#Comment by 😂 (talk | contribs)   15:30, 28 December 2010

It's that simple? I assumed it wouldn't be so straightforward

#Comment by Platonides (talk | contribs)   15:33, 28 December 2010

They should still accept the subscription, but that's not something to change.

#Comment by 😂 (talk | contribs)   15:34, 28 December 2010

Huh?

#Comment by Platonides (talk | contribs)   15:36, 28 December 2010

I mean, mailman will send a message like "Do you agree to being subscribed to foo-list? If so, reply to this email or go to this url."

#Comment by 😂 (talk | contribs)   15:50, 28 December 2010

Well I assume we'd still want confirmation to protect against typos and people signing someone else up.

#Comment by Platonides (talk | contribs)   15:55, 28 December 2010

Of course.

#Comment by Krinkle (talk | contribs)   04:04, 3 January 2011

See also bug 26550 which requests the proper reimplementation of this feature.

Status & tagging log