r78381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78380‎ | r78381 | r78382 >
Date:15:49, 14 December 2010
Author:demon
Status:ok
Tags:
Comment:
Remove big commented list of URLs (added in r61078) that this class will never be testing. Core tests shouldn't depend on extensions and they were confusing my grepping too.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/HttpTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/HttpTest.php
@@ -191,50 +191,6 @@
192192 $this->runHTTPRequests();
193193 }
194194
195 - /* ./extensions/SpamBlacklist/SpamBlacklist_body.php:164: $httpText = Http::get( $fileName ); */
196 - /* ./extensions/ApiSVGProxy/ApiSVGProxy.body.php:44: $contents = Http::get( $file->getFullUrl() ); */
197 - /* ./extensions/BookInformation/drivers/IsbnDb.php:24: if( ( $xml = Http::get( $uri ) ) !== false ) { */
198 - /* ./extensions/BookInformation/drivers/Amazon.php:23: if( ( $xml = Http::get( $uri ) ) !== false ) { */
199 - /* ./extensions/TitleBlacklist/TitleBlacklist.list.php:217: $result = Http::get( $url ); */
200 - /* ./extensions/TSPoll/TSPoll.php:68: $get_server = Http::get( 'http://toolserver.org/~jan/poll/dev/main.php?page=wiki_output&id='.$id ); */
201 - /* ./extensions/TSPoll/TSPoll.php:70: $get_server = Http::get( 'http://toolserver.org/~jan/poll/main.php?page=wiki_output&id='.$id ); */
202 - /* ./extensions/DoubleWiki/DoubleWiki.php:56: $translation = Http::get( $url.$sep.'action=render' ); */
203 - /* ./extensions/ExternalPages/ExternalPages_body.php:177: $serializedText = Http::get( $this->mPageURL ); */
204 - /* ./extensions/Translate/utils/TranslationHelpers.php:143: $suggestions = Http::get( $url, $timeout ); */
205 - /* ./extensions/Translate/SpecialImportTranslations.php:169: $filedata = Http::get( $url ); ; */
206 - /* ./extensions/Translate/TranslateEditAddons.php:338: $suggestions = Http::get( $url, $timeout ); */
207 - /* ./extensions/SecurePoll/includes/user/Auth.php:283: $value = Http::get( $url, 20, $curlParams ); */
208 - /* ./extensions/DumpHTML/dumpHTML.inc:778: $contents = Http::get( $url ); */
209 - /* ./extensions/DumpHTML/dumpHTML.inc:1298: $contents = Http::get( $sourceUrl ); */
210 - /* ./extensions/DumpHTML/dumpHTML.inc:1373: $contents = Http::get( $sourceUrl ); */
211 - /* ./phase3/maintenance/rebuildInterwiki.inc:101: $intermap = Http::get( 'http://meta.wikimedia.org/w/index.php?title=Interwiki_map&action=raw', 30 ); */
212 - /* ./phase3/maintenance/findhooks.php:98: $allhookdata = Http::get( 'http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:MediaWiki_hooks&cmlimit=500&format=php' ); */
213 - /* ./phase3/maintenance/findhooks.php:109: $oldhookdata = Http::get( 'http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:Removed_hooks&cmlimit=500&format=php' ); */
214 - /* ./phase3/maintenance/dumpInterwiki.inc:95: $intermap = Http::get( 'http://meta.wikimedia.org/w/index.php?title=Interwiki_map&action=raw', 30 ); */
215 - /* ./phase3/includes/parser/Parser.php:3204: $text = Http::get($url); */
216 - /* ./phase3/includes/filerepo/ForeignAPIRepo.php:131: $data = Http::get( $url ); */
217 - /* ./phase3/includes/filerepo/ForeignAPIRepo.php:205: $thumb = Http::get( $foreignUrl ); */
218 - /* ./phase3/includes/filerepo/File.php:1105: $res = Http::get( $renderUrl ); */
219 - /* ./phase3/includes/GlobalFunctions.php:2760: * @deprecated Use Http::get() instead */
220 - /* ./phase3/includes/GlobalFunctions.php:2764: return Http::get( $url ); */
221 - /* ./phase3/includes/ExternalStoreHttp.php:18: $ret = Http::get( $url ); */
222 - /* ./phase3/includes/Import.php:357: $data = Http::get( $src ); */
223 - /* ./extensions/ExternalData/ED_Utils.php:291: return Http::get( $url, 'default', array(CURLOPT_SSL_VERIFYPEER => false) ); */
224 - /* ./extensions/ExternalData/ED_Utils.php:293: return Http::get( $url ); */
225 - /* ./extensions/ExternalData/ED_Utils.php:306: $page = Http::get( $url, 'default', array(CURLOPT_SSL_VERIFYPEER => false) ); */
226 - /* ./extensions/ExternalData/ED_Utils.php:308: $page = Http::get( $url ); */
227 - /* ./extensions/CodeReview/backend/Subversion.php:320: $blob = Http::get( $target, $this->mTimeout ); */
228 - /* ./extensions/AmazonPlus/AmazonPlus.php:214: $this->response = Http::get( $urlstr ); */
229 - /* ./extensions/StaticWiki/StaticWiki.php:24: $text = Http::get( $url ) ; */
230 - /* ./extensions/StaticWiki/StaticWiki.php:64: $history = Http::get ( $wgStaticWikiExternalSite . "index.php?title=" . urlencode ( $url_title ) . "&action=history" ) ; */
231 - /* ./extensions/Configure/scripts/findSettings.php:126: $cont = Http::get( "http://www.mediawiki.org/w/index.php?title={$page}&action=raw" ); */
232 - /* ./extensions/TorBlock/TorBlock.class.php:148: $data = Http::get( $url ); */
233 - /* ./extensions/HoneypotIntegration/HoneypotIntegration.class.php:60: $data = Http::get( $wgHoneypotURLSource, 'default', */
234 - /* ./extensions/SemanticForms/includes/SF_Utils.inc:378: $page_contents = Http::get($url); */
235 - /* ./extensions/LocalisationUpdate/LocalisationUpdate.class.php:172: $basefilecontents = Http::get( $basefile ); */
236 - /* ./extensions/APC/SpecialAPC.php:245: $rss = Http::get( 'http://pecl.php.net/feeds/pkg_apc.rss' ); */
237 - /* ./extensions/Interlanguage/Interlanguage.php:56: $a = Http::get( $url ); */
238 - /* ./extensions/MWSearch/MWSearch_body.php:492: $data = Http::get( $searchUrl, $wgLuceneSearchTimeout, $httpOpts); */
239195 function runHTTPGets( $proxy = null ) {
240196 $opt = array();
241197

Follow-up revisions

RevisionCommit summaryAuthorDate
r78385Missed another comment in r78381demon16:31, 14 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61078follow-up r60811 clean up code, write some tests for the existing uses of Htt...mah05:56, 15 January 2010

Status & tagging log