r78351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78350‎ | r78351 | r78352 >
Date:00:08, 14 December 2010
Author:krinkle
Status:ok
Tags:
Comment:
merging the two addModules() calls into one, (they take an array, so might as well me together); + using mw instead of mediaWiki in mediawiki.util.js
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1617,8 +1617,7 @@
16181618 $sk = $wgUser->getSkin();
16191619
16201620 // Add base resources
1621 - $this->addModules( array( 'mediawiki.legacy.wikibits' ) );
1622 - $this->addModules( array( 'mediawiki.util' ) );
 1621+ $this->addModules( array( 'mediawiki.legacy.wikibits', 'mediawiki.util' ) );
16231622
16241623 // Add various resources if required
16251624 if ( $wgUseAjax ) {
Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
@@ -4,7 +4,7 @@
55
66 (function ($, mw) {
77
8 - mediaWiki.util = {
 8+ mw.util = {
99
1010 /* Initialisation */
1111 'initialised' : false,
@@ -363,6 +363,6 @@
364364
365365 };
366366
367 - mediaWiki.util.init();
 367+ mw.util.init();
368368
369 -})(jQuery, mediaWiki);
 369+})(jQuery, mediaWiki);
\ No newline at end of file

Status & tagging log