r77315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77314‎ | r77315 | r77316 >
Date:00:21, 26 November 2010
Author:mah
Status:deferred
Tags:
Comment:
follow r77243 -- unit test was coded to hide the bug... doh! fix it up
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/TitlePermissionTest.php
@@ -610,9 +610,9 @@
611611 # $short
612612 $this->assertEquals( array( array( 'confirmedittext' ) ),
613613 self::$title->getUserPermissionsErrors( 'move-target', self::$user ) );
 614+ $wgEmailConfirmToEdit = false;
614615 $this->assertEquals( true, self::$title->userCan( 'move-target' ) );
615616
616 - $wgEmailConfirmToEdit = false;
617617 # $wgEmailConfirmToEdit && !$user->isEmailConfirmed() && $action != 'createaccount'
618618 $this->assertEquals( array( ),
619619 self::$title->getUserPermissionsErrors( 'move-target',

Follow-up revisions

RevisionCommit summaryAuthorDate
r77316follow r77243 and r77315 which claimed to fix, but didn't -- fix the unit tes...mah01:16, 26 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77243followup r65504 — actually check that we hav errors before returnning from ...mah19:52, 24 November 2010

Status & tagging log