| Index: trunk/extensions/CodeReview/ui/CodeRevisionAuthorView.php |
| — | — | @@ -45,10 +45,9 @@ |
| 46 | 46 | parent::execute(); |
| 47 | 47 | } |
| 48 | 48 | |
| 49 | | - function getSpecializedWhereClause( $dbr ) { |
| | 49 | + function getSpecializedWhereClause() { |
| 50 | 50 | return array( 'cr_author' => $this->mAuthor ); |
| 51 | 51 | } |
| 52 | | - |
| 53 | 52 | } |
| 54 | 53 | |
| 55 | 54 | class SvnRevAuthorTablePager extends SvnRevTablePager { |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php |
| — | — | @@ -50,14 +50,14 @@ |
| 51 | 51 | * @param string $status Status to set the revision to |
| 52 | 52 | * @param Array $addTags Tags to add to the revision |
| 53 | 53 | * @param Array $removeTags Tags to remove from the Revision |
| 54 | | - * @param Array $signoffFlags Array of sign-off flags to add |
| | 54 | + * @param Array $addSignoffs Array of sign-off flags to add |
| 55 | 55 | * @param Array $strikeSignoffs Array of sign-off IDs to strike |
| 56 | 56 | * @param string $commentText Comment to add to the revision |
| 57 | 57 | * @param null|int $parent What the parent comment is (if a subcomment) |
| 58 | 58 | * @param int $review (unused) |
| 59 | 59 | * @return int Comment ID if added, else 0 |
| 60 | 60 | */ |
| 61 | | - public function revisionUpdate( $status, $addTags, $removeTags, $signoffFlags, $strikeSignoffs, |
| | 61 | + public function revisionUpdate( $status, $addTags, $removeTags, $addSignoffs, $strikeSignoffs, |
| 62 | 62 | $commentText, $parent = null, $review = 0 ) { |
| 63 | 63 | if ( !$this->mRev ) { |
| 64 | 64 | return false; |
| — | — | @@ -85,8 +85,8 @@ |
| 86 | 86 | $this->mRev->changeTags( $validAddTags, $validRemoveTags, $wgUser ); |
| 87 | 87 | } |
| 88 | 88 | // Add any signoffs |
| 89 | | - if ( count( $signoffFlags ) && $this->validPost( 'codereview-signoff' ) ) { |
| 90 | | - $this->mRev->addSignoff( $wgUser, $signoffFlags ); |
| | 89 | + if ( count( $addSignoffs ) && $this->validPost( 'codereview-signoff' ) ) { |
| | 90 | + $this->mRev->addSignoff( $wgUser, $addSignoffs ); |
| 91 | 91 | } |
| 92 | 92 | // Strike any signoffs |
| 93 | 93 | if ( count( $strikeSignoffs ) && $this->validPost( 'codereview-signoff' ) ) { |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php |
| — | — | @@ -212,10 +212,7 @@ |
| 213 | 213 | } |
| 214 | 214 | } |
| 215 | 215 | |
| 216 | | - /** |
| 217 | | - * @todo Document |
| 218 | | - */ |
| 219 | | - function getSpecializedWhereClause( $dbr ) { |
| | 216 | + function getSpecializedWhereClause() { |
| 220 | 217 | return array(); |
| 221 | 218 | } |
| 222 | 219 | |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionStatusView.php |
| — | — | @@ -11,7 +11,7 @@ |
| 12 | 12 | return new SvnRevStatusTablePager( $this, $this->mStatus ); |
| 13 | 13 | } |
| 14 | 14 | |
| 15 | | - function getSpecializedWhereClause( $dbr ) { |
| | 15 | + function getSpecializedWhereClause() { |
| 16 | 16 | return array( 'cr_status' => $this->mStatus ); |
| 17 | 17 | } |
| 18 | 18 | } |