r77243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77242‎ | r77243 | r77244 >
Date:19:52, 24 November 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
followup r65504 — actually check that we hav errors before returnning from checkUserBlock when short circuited.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -1475,7 +1475,7 @@
14761476 * @see checkQuickPermissions for parameter information
14771477 */
14781478 private function checkUserBlock( $action, $user, $errors, $doExpensiveQueries, $short ) {
1479 - if( $short ) {
 1479+ if( $short && count( $errors ) > 0 ) {
14801480 return $errors;
14811481 }
14821482

Follow-up revisions

RevisionCommit summaryAuthorDate
r77315follow r77243 -- unit test was coded to hide the bug... doh! fix it upmah00:21, 26 November 2010
r77316follow r77243 and r77315 which claimed to fix, but didn't -- fix the unit tes...mah01:16, 26 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65504* Refactor super-long title function...mah06:22, 24 April 2010

Comments

#Comment by Hashar (talk | contribs)   20:43, 25 November 2010

breaks test: 

TitlePermissionTest::testUserBlock
Failed asserting that <boolean:false> matches expected <boolean:true>.

http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw?log=log20101124203235

#Comment by MarkAHershberger (talk | contribs)   03:20, 26 November 2010

see r77316

Status & tagging log