r77316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77315‎ | r77316 | r77317 >
Date:01:16, 26 November 2010
Author:mah
Status:ok
Tags:
Comment:
follow r77243 and r77315 which claimed to fix, but didn't -- fix the unit test was that accidently hide the bug
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/TitlePermissionTest.php
@@ -632,7 +632,7 @@
633633 self::$title->getUserPermissionsErrors( 'move-target',
634634 self::$user ) );
635635
636 - $this->assertEquals( true,
 636+ $this->assertEquals( false,
637637 self::$title->userCan( 'move-target', self::$user ) );
638638
639639 global $wgLocalTZoffset;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77243followup r65504 — actually check that we hav errors before returnning from ...mah19:52, 24 November 2010
r77315follow r77243 -- unit test was coded to hide the bug... doh! fix it upmah00:21, 26 November 2010

Status & tagging log