r72349 MediaWiki - Code Review archive

After svn up of my local testwiki I am unable to run maintenance/update.php:

D:\F_Programmierung\xampp\htdocs\wiki_neu\maintenance>php update.php
A database error has occurred
Query: DELETE FROM `msg_resource`
Function: MessageBlobStore::clear
Error: 1146 Table 'wikidb_neu.msg_resource' doesn't exist (localhost)

Fixed with r72357 by Trevor. Thanks.

Running a local wiki with $wgDefaultSkin = 'vector'; shows pages w/o any CSS.

$wgDefaultSkin = 'monobook'; looks good.

It could be that there are errors or warnings in the CSS being output by load.php . Could you check the CSS output or the logs or something to figure out what errors/warnings you may be getting?

From Firefox error console (translated from German):

Warning: Unclosed string '"?2009-09-08T19:28:20Z) center ....' found. Error at execution for the value of 'background'. Declaration ignored. Source file: http://localhost/wiki_neu/load.php?modules=mediawiki.legacy.shared%7Cmediawiki.legacy.commonPrint%7Cvector&lang=de&debug=&skin=vector&only=styles Zeile: 2

Warning: Exunpexted EOF during search for } . Quelldatei: http://localhost/wiki_neu/load.php?modules=mediawiki.legacy.shared%7Cmediawiki.legacy.commonPrint%7Cvector&lang=de&debug=&skin=vector&only=styles Zeile: 2

Could you pastebin the content at that URL somewhere?

http://dpaste.org/NZMe/

The culprit seems to be this:

background-image:url(data:;base64,iVBORw0K

Normally that would say something like data:image/png;base64, but it looks like PHP was unable to determine the MIME type of the file (are you running this on Windows by any chance?) and just used an empty string for the MIME type. That's a bug, thanks for reporting it.

(are you running this on Windows by any chance?)

Yes. Windows 7, Firefox 3.6.9

1. ChangesList.php beginRecentChangesList() now returns an unused $script variable.
2. CSSJanus / CSSMin should go into lib
3. Non page-specific pieces of mediaWiki.config should go into load.php (skin, stylepath, wgUrlProtocols, wgArticlePath, wgScriptPath, wgScriptExtension, wgScript, wgVariantArticlePath, wgActionPaths, wgServer, wgUserName, wgUserGroups, wgUserLanguage, wgContentLanguage, wgBreakFrames, wgVersion, wgEnableAPI, wgEnableWriteAPI, wgSeparatorTransformTable, wgDigitTransformTable, wgMainPageTitle, wgFormattedNamespaces,wgSiteName)
4. Unused $wgContLang added to MessageCache::figureMessage
5. Wouldn't the removal of gen=js to RawPage.php mean that people getting an old page with gen=js scripts in it is exposed -given a poor browser not caring about the mime- to javascript-like code stored in - ? We should detect it to not return the page.
6. ajaxwatch.js window.wgAjaxWatch could be removed.
7. Wouldn't be preferable to have /* @embed */ comments in the same line as the background-image?
8. MessageBlobStore::insertMessageBlob selects the message blob from the database after it has generated it. Moreover, using an unitialised variable $dbr so that would be a fatal.

Gerenally good points, but #7 - no, that's not really the convention, but it also would still work just fine so it's kind of a moot point. The detection doesn't care about lines at all.

9. WebInstallerOutput needs to be put up to date (eg. it will no longer be able to load jQuery).

There is not load.php5. Also RELEASE-NOTES need updating.

.php5 issue resolved in r72391.

Adding scaptrap until everything gets sorted. Has broken FlaggedRevs. Probably other WMF-used extensions as well. :)

I hope nobody tries to live merge the resource loader.

Vector CSS is broken on my testwiki (mediawiki.legacy.shared), giving "Found unclosed string "?2009-08-06...<whole file>" and "Unexpected end of file while searching for closing } of declaration block."

Vector CSS is broken on my testwiki (mediawiki.legacy.shared), giving "Found unclosed string "?2009-08-06...<whole file>" and "Unexpected end of file while searching for closing } of declaration block."

• sigh*...double post. It white-screened the first time, didn't think it went through.

Looking at the CSS I have "...a.feedlink{background:url(skins/common/images/feed-icon.png"?2009-08-06T03:03:20Z) center left...", which is where the problem seems to be.

Is this still an issue? I may need more information to reproduce.

I think it's gone.

All issues mentioned here have been fixed, resetting to new.

Marking resolved. All the issues with the initial merge have been pretty much ironed out by now. Issues with commits to RL should go with those commits, outright bugs in BZ at this point.

The added direction:ltr in vector/main-ltr.css overrides direction set in PHP r60786.

I don't see this one being resolved yet.

Then open bugs, we don't need to leave this merge marked as fixme .

Bug 28572 has been added to the database.