r72357 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72356‎ | r72357 | r72358 >
Date:07:54, 4 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Followup to r72349: fix database error caused by update.php indirectly (via LocalisationCache::recache() and MessageBlobStore::clear()) trying to clear out the msg_resource table before it's even created it.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
——@@ -623,7 +623,11 @@
624624 $this->store->finishWrite();
625625
626626 # Clear out the MessageBlobStore
627 - MessageBlobStore::clear();
 627+ # HACK: If using a null (i.e. disabled) storage backend, we
 628+ # can't write to the MessageBlobStore either
 629+ if ( !$this->store instanceof LCStore_Null ) {
 630+ MessageBlobStore::clear();
 631+ }
628632
629633 wfProfileOut( __METHOD__ );
630634 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72349Merging resourceloader branch into trunk. Full documentation is at http://www...catrope04:00, 4 September 2010

Comments

#Comment by Platonides (talk | contribs)   11:47, 4 September 2010

I still get (on running the wiki) 

Query: DELETE FROM msg_resource
Function: MessageBlobStore::clear
Error: 8 attempt to write a readonly database
#Comment by Platonides (talk | contribs)   11:48, 4 September 2010

Happening in sqlite

#Comment by MaxSem (talk | contribs)   09:34, 5 September 2010

Can't reproduce.

#Comment by Platonides (talk | contribs)   16:22, 5 September 2010

It was my fault. The file containing the sqlite db was read only.

Still, write access shouldn't be needed just for viewing.

#Comment by MaxSem (talk | contribs)   16:24, 5 September 2010

Page views may involve other write activity, such as processing jobs, so this is not a bug.

#Comment by Platonides (talk | contribs)   16:34, 5 September 2010

Sure, if there were pendign jobs. Increasing page view stats would be more appropiate here.

The localization cache continue working after an expire, but the MessageBlobStore would need to be explicitely disabled.

#Comment by MarkAHershberger (talk | contribs)   20:36, 4 September 2010

Note that codurr was reporting a problem in #mediawiki at 21:03 EDT or ~18:00 PDT

Status & tagging log