r72373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72372‎ | r72373 | r72374 >
Date:13:27, 4 September 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow-up r72349.
Remove unused globals $wgStylePath, $wgStyleVersion, $wgUser and the no longer used $wgJQueryOnEveryPage.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)
  • /trunk/phase3/includes/MessageCache.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/ResourceLoaderContext.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -579,7 +579,7 @@
580580 * Add style sheets and supporting JS for diff display.
581581 */
582582 function showDiffStyle() {
583 - global $wgStylePath, $wgStyleVersion, $wgOut;
 583+ global $wgOut;
584584 $wgOut->addModules( 'mediawiki.legacy.diff' );
585585 }
586586
Index: trunk/phase3/includes/MessageCache.php
@@ -750,6 +750,7 @@
751751 # Invalidate all local caches
752752 $this->mMemc->delete( wfMemcKey( 'messages', $code, 'hash' ) );
753753 }
 754+ $this->mLoadedLanguages = array();
754755 }
755756
756757 /**
@@ -811,7 +812,7 @@
812813 }
813814
814815 public function figureMessage( $key ) {
815 - global $wgContLanguageCode, $wgContLang;
 816+ global $wgContLanguageCode;
816817 $pieces = explode( '/', $key );
817818 if( count( $pieces ) < 2 )
818819 return array( $key, $wgContLanguageCode );
Index: trunk/phase3/includes/ResourceLoaderContext.php
@@ -38,7 +38,7 @@
3939 /* Methods */
4040
4141 public function __construct( WebRequest $request, $server ) {
42 - global $wgUser, $wgLang, $wgDefaultSkin;
 42+ global $wgLang, $wgDefaultSkin;
4343
4444 $this->request = $request;
4545 $this->server = $server;
Index: trunk/phase3/includes/HTMLForm.php
@@ -156,7 +156,7 @@
157157 static function addJS() {
158158 if ( self::$jsAdded ) return;
159159
160 - global $wgOut, $wgStylePath;
 160+ global $wgOut;
161161
162162 $wgOut->addModules( 'mediawiki.legacy.htmlform' );
163163 }
Index: trunk/phase3/includes/OutputPage.php
@@ -1565,7 +1565,7 @@
15661566 global $wgContLanguageCode, $wgDebugRedirects, $wgMimeType;
15671567 global $wgUseAjax, $wgAjaxWatch;
15681568 global $wgEnableMWSuggest, $wgUniversalEditButton;
1569 - global $wgArticle, $wgJQueryOnEveryPage;
 1569+ global $wgArticle;
15701570
15711571 if( $this->mDoNothing ) {
15721572 return;
@@ -2301,7 +2301,7 @@
23022302 */
23032303 function getHeadScripts( Skin $sk ) {
23042304 global $wgUser, $wgRequest, $wgJsMimeType;
2305 - global $wgStylePath, $wgStyleVersion, $wgUseSiteJs;
 2305+ global $wgUseSiteJs;
23062306
23072307 // Statup - this will immediately load jquery and mediawiki modules
23082308 $scripts = self::makeResourceLoaderLink( $sk, 'startup', 'scripts' );
Index: trunk/phase3/includes/ChangesList.php
@@ -601,7 +601,7 @@
602602 * @return String
603603 */
604604 public function beginRecentChangesList() {
605 - global $wgStylePath, $wgStyleVersion, $wgOut;
 605+ global $wgOut;
606606 $this->rc_cache = array();
607607 $this->rcMoveIndex = 0;
608608 $this->rcCacheIndex = 0;
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -195,7 +195,6 @@
196196 wfMsgForContent( 'ipbreason-dropdown' ),
197197 wfMsgForContent( 'ipbreasonotherlist' ), $this->BlockReasonList, 'wpBlockDropDown', 4 );
198198
199 - global $wgStylePath, $wgStyleVersion;
200199 $wgOut->addModules( 'mediawiki.legacy.block' );
201200 $wgOut->addHTML(
202201 Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL( 'action=submit' ), 'id' => 'blockip' ) ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72349Merging resourceloader branch into trunk. Full documentation is at http://www...catrope04:00, 4 September 2010

Status & tagging log