r72564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72563‎ | r72564 | r72565 >
Date:22:55, 7 September 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow-up r72349. The new makeResourceLoaderLink() doesn't need $wgScriptPath.

I quite agree with the TODO. Moving to ResourceLoader class seems a good idea.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -2281,7 +2281,7 @@
22822282 }
22832283
22842284 static function makeResourceLoaderLink( $skin, $modules, $only ) {
2285 - global $wgUser, $wgLang, $wgRequest, $wgScriptPath;
 2285+ global $wgUser, $wgLang, $wgRequest;
22862286 // TODO: Should this be a static function of ResourceLoader instead?
22872287 $query = array(
22882288 'modules' => implode( '|', array_unique( (array) $modules ) ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72349Merging resourceloader branch into trunk. Full documentation is at http://www...catrope04:00, 4 September 2010

Status & tagging log