r64881 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64880‎ | r64881 | r64882 >
Date:14:11, 10 April 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
fixing bug 23139 (introduced in r59655) which broke edit conflict resolution
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1295,7 +1295,7 @@
12961296 // and fallback to the raw wpTextbox1 since editconflicts can't be
12971297 // resolved between page source edits and custom ui edits using the
12981298 // custom edit ui.
1299 - $this->showTextbox1();
 1299+ $this->showTextbox1( null, $this->getContent() );
13001300 } else {
13011301 $this->showContentForm();
13021302 }
@@ -1775,7 +1775,11 @@
17761776 $wgOut->addHTML( " <span class='editHelp'>{$cancel}{$separator}{$edithelp}</span>\n" );
17771777 $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
17781778 }
1779 -
 1779+
 1780+ /*
 1781+ * Show an edit conflict. textbox1 is already shown in showEditForm().
 1782+ * If you want to use another entry point to this function, be careful.
 1783+ */
17801784 protected function showConflict() {
17811785 global $wgOut;
17821786 $this->textbox2 = $this->textbox1;

Follow-up revisions

RevisionCommit summaryAuthorDate
r648821.16wmf4: MFT r64881catrope14:29, 10 April 2010
r65376MFT r64881, bug 23139: Fixed a bug in edit conflict resolution, where both te...tstarling11:06, 21 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59655EditPage refactor and improvements....dantman07:22, 2 December 2009

Status & tagging log