r64882 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64881‎ | r64882 | r64883 >
Date:14:29, 10 April 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r64881
Modified paths:
  • /branches/wmf/1.16wmf4/includes/EditPage.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/EditPage.php
@@ -1286,7 +1286,7 @@
12871287 // and fallback to the raw wpTextbox1 since editconflicts can't be
12881288 // resolved between page source edits and custom ui edits using the
12891289 // custom edit ui.
1290 - $this->showTextbox1();
 1290+ $this->showTextbox1( null, $this->getContent() );
12911291 } else {
12921292 $this->showContentForm();
12931293 }
@@ -1760,7 +1760,11 @@
17611761 $wgOut->addHTML( " <span class='editHelp'>{$cancel}{$separator}{$edithelp}</span>\n" );
17621762 $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
17631763 }
1764 -
 1764+
 1765+ /*
 1766+ * Show an edit conflict. textbox1 is already shown in showEditForm().
 1767+ * If you want to use another entry point to this function, be careful.
 1768+ */
17651769 protected function showConflict() {
17661770 global $wgOut;
17671771 $this->textbox2 = $this->textbox1;
Property changes on: branches/wmf/1.16wmf4/includes/EditPage.php
___________________________________________________________________
Name: svn:mergeinfo
17681772 + /branches/REL1_15/phase3/includes/EditPage.php:51646
/branches/sqlite/includes/EditPage.php:58211-58321
/branches/wmf-deployment/includes/EditPage.php:53381,60970
/trunk/phase3/includes/EditPage.php:63549,63764,63897-63901,64881

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64881fixing bug 23139 (introduced in r59655) which broke edit conflict resolutionchurchofemacs14:11, 10 April 2010

Status & tagging log