r64880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64879‎ | r64880 | r64881 >
Date:14:06, 10 April 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r62006 readding return $ok; to what is now runTests()
This fixes parserTests.php not returning 0 on success.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
——@@ -289,7 +289,7 @@
290290
291291 function runTests($tests) {
292292 $ok = true;
293 - foreach($tests as $i => $t) {
 293+ foreach($tests as $i => $t) {
294294 $result =
295295 $this->runTest($t['test'], $t['input'], $t['result'], $t['options'], $t['config']);
296296 $ok = $ok && $result;
——@@ -298,6 +298,7 @@
299299 if ( $this->showProgress ) {
300300 print "\n";
301301 }
 302+ return $ok;
302303 }
303304
304305 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62006PHPUnit now sees individual parser tests as separate tests. This...mah04:01, 5 February 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   17:22, 18 May 2010

Watch the use of whitespace.

#Comment by Platonides (talk | contribs)   19:21, 18 May 2010

My version is fine. It was the previous one which used 4 spaces instead of a couple of tabs.

#Comment by MarkAHershberger (talk | contribs)   19:46, 18 May 2010

/me slinks away in silence

#Comment by Platonides (talk | contribs)   19:51, 18 May 2010

Not so fine, it seems. I was comparing with the wrong version. I tried to change them to tabs but I don't know which editor used, it ended up as spaces (fixed on r65907 and r65973).

Status & tagging log