r65376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65375‎ | r65376 | r65377 >
Date:11:06, 21 April 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r64881, bug 23139: Fixed a bug in edit conflict resolution, where both textboxes showed the same text.
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes (modified) (history)
  • /branches/REL1_16/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_16/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/REL1_16/phase3/includes/EditPage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/LocalisationCache.php (modified) (history)
  • /branches/REL1_16/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/api (modified) (history)
  • /branches/REL1_16/phase3/includes/diff (modified) (history)
  • /branches/REL1_16/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials (modified) (history)

Diff [purge]

Property changes on: branches/REL1_16/phase3/includes/diff
___________________________________________________________________
Name: svn:mergeinfo
11 - /branches/REL1_15/phase3/includes/diff:51646
/branches/sqlite/includes/diff:58211-58321
/branches/wmf-deployment/includes/diff:53381
/trunk/phase3/includes/diff:63549,63764,63897-63901,64802
22 + /branches/REL1_15/phase3/includes/diff:51646
/branches/sqlite/includes/diff:58211-58321
/branches/wmf-deployment/includes/diff:53381
/trunk/phase3/includes/diff:63549,63764,63897-63901,64802,64881
Property changes on: branches/REL1_16/phase3/includes/json/Services_JSON.php
___________________________________________________________________
Name: svn:mergeinfo
33 - /branches/REL1_15/phase3/includes/api/ApiFormatJson_json.php:51646
/branches/wmf-deployment/includes/api/ApiFormatJson_json.php:53381
/trunk/phase3/includes/json/Services_JSON.php:63549,63764,63897-63901
44 + /branches/REL1_15/phase3/includes/api/ApiFormatJson_json.php:51646
/branches/wmf-deployment/includes/api/ApiFormatJson_json.php:53381
/trunk/phase3/includes/json/Services_JSON.php:63549,63764,63897-63901,64881
Property changes on: branches/REL1_16/phase3/includes/LocalisationCache.php
___________________________________________________________________
Name: svn:mergeinfo
55 - /branches/REL1_15/phase3/includes/LocalisationCache.php:51646
/branches/sqlite/includes/LocalisationCache.php:58211-58321
/branches/wmf-deployment/includes/LocalisationCache.php:53381
/trunk/phase3/includes/LocalisationCache.php:63394,63549,63764,63897-63901
66 + /branches/REL1_15/phase3/includes/LocalisationCache.php:51646
/branches/sqlite/includes/LocalisationCache.php:58211-58321
/branches/wmf-deployment/includes/LocalisationCache.php:53381
/trunk/phase3/includes/LocalisationCache.php:63394,63549,63764,63897-63901,64881
Index: branches/REL1_16/phase3/includes/EditPage.php
@@ -1286,7 +1286,7 @@
12871287 // and fallback to the raw wpTextbox1 since editconflicts can't be
12881288 // resolved between page source edits and custom ui edits using the
12891289 // custom edit ui.
1290 - $this->showTextbox1();
 1290+ $this->showTextbox1( null, $this->getContent() );
12911291 } else {
12921292 $this->showContentForm();
12931293 }
@@ -1760,7 +1760,11 @@
17611761 $wgOut->addHTML( " <span class='editHelp'>{$cancel}{$separator}{$edithelp}</span>\n" );
17621762 $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
17631763 }
1764 -
 1764+
 1765+ /*
 1766+ * Show an edit conflict. textbox1 is already shown in showEditForm().
 1767+ * If you want to use another entry point to this function, be careful.
 1768+ */
17651769 protected function showConflict() {
17661770 global $wgOut;
17671771 $this->textbox2 = $this->textbox1;
Property changes on: branches/REL1_16/phase3/includes/OutputPage.php
___________________________________________________________________
Name: svn:mergeinfo
17681772 - /branches/REL1_15/phase3/includes/OutputPage.php:51646
/branches/wmf-deployment/includes/OutputPage.php:53381,57468
/trunk/phase3/includes/OutputPage.php:63549,63764,63897-63901
17691773 + /branches/REL1_15/phase3/includes/OutputPage.php:51646
/branches/wmf-deployment/includes/OutputPage.php:53381,57468
/trunk/phase3/includes/OutputPage.php:63549,63764,63897-63901,64881
Property changes on: branches/REL1_16/phase3/includes/HistoryPage.php
___________________________________________________________________
Name: svn:mergeinfo
17701774 - /branches/REL1_15/phase3/includes/PageHistory.php:51646
/trunk/phase3/includes/HistoryPage.php:63549,63764,63897-63901
17711775 + /branches/REL1_15/phase3/includes/PageHistory.php:51646
/trunk/phase3/includes/HistoryPage.php:63549,63764,63897-63901,64881
Property changes on: branches/REL1_16/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
17721776 - /branches/REL1_15/phase3/includes/api:51646
/branches/sqlite/includes/api:58211-58321
/branches/wmf-deployment/includes/api:53381,59952
/trunk/phase3/includes/api:63549,63764,63897-63901,64454
17731777 + /branches/REL1_15/phase3/includes/api:51646
/branches/sqlite/includes/api:58211-58321
/branches/wmf-deployment/includes/api:53381,59952
/trunk/phase3/includes/api:63549,63764,63897-63901,64454,64881
Property changes on: branches/REL1_16/phase3/includes/ChangesList.php
___________________________________________________________________
Name: svn:mergeinfo
17741778 - /branches/REL1_15/phase3/includes/ChangesList.php:51646
/branches/wmf-deployment/includes/ChangesList.php:53381,57589
/trunk/phase3/includes/ChangesList.php:63549,63764,63897-63901
17751779 + /branches/REL1_15/phase3/includes/ChangesList.php:51646
/branches/wmf-deployment/includes/ChangesList.php:53381,57589
/trunk/phase3/includes/ChangesList.php:63549,63764,63897-63901,64881
Property changes on: branches/REL1_16/phase3/includes/ConfEditor.php
___________________________________________________________________
Name: svn:mergeinfo
17761780 - /trunk/phase3/includes/ConfEditor.php:63549,63764,63897-63901
17771781 + /trunk/phase3/includes/ConfEditor.php:63549,63764,63897-63901,64881
Property changes on: branches/REL1_16/phase3/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
17781782 - /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967
/trunk/phase3/includes/specials:63045,63047,63490,63549,63764,63897-63901,64180,64837,64846,64860,64862
17791783 + /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967
/trunk/phase3/includes/specials:63045,63047,63490,63549,63764,63897-63901,64180,64837,64846,64860,64862,64881
Property changes on: branches/REL1_16/phase3/includes
___________________________________________________________________
Name: svn:mergeinfo
17801784 - /branches/REL1_15/phase3/includes:51646
/branches/sqlite/includes:58211-58321
/branches/wmf-deployment/includes:53381
/trunk/phase3/includes:63549,63764,63897-63901
17811785 + /branches/REL1_15/phase3/includes:51646
/branches/sqlite/includes:58211-58321
/branches/wmf-deployment/includes:53381
/trunk/phase3/includes:63549,63764,63897-63901,64881
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -49,6 +49,8 @@
5050 * (bug 23117) Fixed API rollback, was returning "badtoken" for valid requests
5151 * (bug 23127) Re-added missing $1 parameter to the uploadtext message
5252 * Fixed a bug in the Vector skin where personal tools display behind the logo
 53+* (bug 23139) Fixed a bug in edit conflict resolution, where both textboxes
 54+ showed the same text.
5355
5456 === Changes since 1.16 beta 1 ===
5557

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64881fixing bug 23139 (introduced in r59655) which broke edit conflict resolutionchurchofemacs14:11, 10 April 2010

Status & tagging log