r65907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65906‎ | r65907 | r65908 >
Date:16:39, 4 May 2010
Author:platonides
Status:ok
Tags:
Comment:
Reading a parser test file with no tests matching the regex was counted as a FAIL.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -289,7 +289,7 @@
290290
291291 function runTests($tests) {
292292 $ok = true;
293 - foreach($tests as $i => $t) {
 293+ foreach($tests as $i => $t) {
294294 $result =
295295 $this->runTest($t['test'], $t['input'], $t['result'], $t['options'], $t['config']);
296296 $ok = $ok && $result;
@@ -1592,10 +1592,10 @@
15931593 if(fseek($this->fh, 0)) {
15941594 wfDie( "Couldn't fseek to the start of '$filename'\n" );
15951595 }
1596 - $this->index = 0;
 1596+ $this->index = -1;
15971597 $this->lineNum = 0;
15981598 $this->eof = false;
1599 - $this->readNextTest();
 1599+ $this->next();
16001600
16011601 return true;
16021602 }

Status & tagging log