r58959 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58958‎ | r58959 | r58960 >
Date:17:54, 12 November 2009
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Run patched version of stylize.php (http://pywiki.pastey.net/128379 for diff) on non-lib non-minimised JavaScript files in js2, except for 3 files locked by timstarling. mdale will run tests on this. Should not be considered anywhere near stable until reviewed (!!!)

The script had some trouble processing some of the regular expressions. Those were put back to their original formatting. Some were updated manually, others were not.
Modified paths:
  • /trunk/phase3/js2/ajaxcategories.js (modified) (history)
  • /trunk/phase3/js2/apiProxyPage.js (modified) (history)
  • /trunk/phase3/js2/editPage.js (modified) (history)
  • /trunk/phase3/js2/js2stopgap.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/dragDropFile.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/remoteSearchDriver.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/searchLibs/archiveOrgSearch.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/searchLibs/baseRemoteSearch.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/searchLibs/flickrSearch.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/searchLibs/mediaWikiSearch.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/searchLibs/metavidSearch.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/simpleUploadForm.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/flowplayerEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/genericEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/htmlEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/javaEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/kplayerEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/nativeEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/omtkEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/vlcEmbed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libMwApi/mw.proxy.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvFirefoggRender.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvPlayList.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvTimedEffectsEdit.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/seqRemoteSearchDriver.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libTimedText/mvTextInterface.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libTimedText/mvTimeTextEdit.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/mv_embed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/skins/ctrlBuilder.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/skins/kskin/kskin.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/tests/testLang.js (modified) (history)
  • /trunk/phase3/js2/remoteMwEmbed.js (modified) (history)
  • /trunk/phase3/js2/uploadPage.js (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r59697Revert js2stopgap to its good state before r58959 tried to prettify it and r5...catrope10:22, 3 December 2009
r92110Readd ajaxCategories from r58959 . This is just a preparation for my next com...diebuche22:15, 13 July 2011

Comments

#Comment by MaxSem (talk | contribs)   08:03, 3 December 2009

Although diff of js2stopgap.js show no changes at all (CodeReview bug?), comparison between what was before this change: <http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/js2/js2stopgap.js?view=markup&pathrev=58093> with version after <http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/js2/js2stopgap.js?view=markup&pathrev=58959> indicates that it introduced some unneeded changes to regexps, thus causing bug 21709 that had to be fixed by r58997, r59666 and r59671.

#Comment by Catrope (talk | contribs)   09:14, 3 December 2009

"on non-lib non-minimised JavaScript files in js2"

Somehow this did change js2stopgap.js , which is an external library. Will revert change to those files in an hour.

Status & tagging log