r58997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58996‎ | r58997 | r58998 >
Date:04:50, 13 November 2009
Author:mrzman
Status:reverted
Tags:
Comment:
Firefox doesn't like spaces between the pattern and the modifiers
Modified paths:
  • /trunk/phase3/js2/js2stopgap.js (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/js2stopgap.js
@@ -610,7 +610,7 @@
611611 };
612612
613613 // exclude the following css properties to add px
614 -var exclude = / z - ? index | font - ? weight | opacity | zoom | line - ? height / i,
 614+var exclude = / z - ? index | font - ? weight | opacity | zoom | line - ? height /i,
615615 // cache defaultView
616616 defaultView = document.defaultView || { },
617617 toString = Object.prototype.toString;
@@ -791,7 +791,7 @@
792792 }
793793
794794 // Make sure we're using the right name for getting the float value
795 - if ( name.match( / float / i ) )
 795+ if ( name.match( / float /i ) )
796796 name = styleFloat;
797797
798798 if ( !force && style && style[ name ] )
@@ -800,10 +800,10 @@
801801 else if ( defaultView.getComputedStyle ) {
802802
803803 // Only "float" is needed here
804 - if ( name.match( / float / i ) )
 804+ if ( name.match( / float /i ) )
805805 name = "float";
806806
807 - name = name.replace( / ( [A - Z] ) / g, "-$1" ).toLowerCase();
 807+ name = name.replace( / ( [A - Z] ) /g, "-$1" ).toLowerCase();
808808
809809 var computedStyle = defaultView.getComputedStyle( elem, null );
810810
@@ -9506,4 +9506,4 @@
95079507 }
95089508
95099509 // Define a dummy mvJsLoader.doLoad() function
9510 -mvJsLoader = { doLoad: function( deps, callback ) { callback(); } };
\ No newline at end of file
 9510+mvJsLoader = { doLoad: function( deps, callback ) { callback(); } };

Follow-up revisions

RevisionCommit summaryAuthorDate
r59697Revert js2stopgap to its good state before r58959 tried to prettify it and r5...catrope10:22, 3 December 2009

Status & tagging log