r59666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59665‎ | r59666 | r59667 >
Date:16:28, 2 December 2009
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
Fix jQuery bug filed upstream as http://dev.jquery.com/ticket/5583 . Also fixes bug 21709 (dialogs freeze in raw/combined mode but not in minified mode). The fact that this worked in minified mode is due to a bug in JSmin, contacted the author about that.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/js2/js2stopgap.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1541,7 +1541,7 @@
15421542 if ( $userInputAttrs )
15431543 $inputAttrs += $userInputAttrs;
15441544 $spanLabelAttrs = array(
1545 - 'class' => $summaryClass,
 1545+ 'class' => @$summaryClass,
15461546 'id' => "wpSummaryLabel"
15471547 );
15481548 if ( is_array($userSpanLabelAttrs) )
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1618,7 +1618,7 @@
16191619 * to ensure that client-side caches do not keep obsolete copies of global
16201620 * styles.
16211621 */
1622 -$wgStyleVersion = '254';
 1622+$wgStyleVersion = '255';
16231623
16241624
16251625 # Server-side caching:
Index: trunk/phase3/js2/js2stopgap.js
@@ -610,7 +610,7 @@
611611 };
612612
613613 // exclude the following css properties to add px
614 -var exclude = / z - ? index | font - ? weight | opacity | zoom | line - ? height /i,
 614+var exclude = /z-?index|font-?weight|opacity|zoom|line-?height/i,
615615 // cache defaultView
616616 defaultView = document.defaultView || { },
617617 toString = Object.prototype.toString;

Follow-up revisions

RevisionCommit summaryAuthorDate
r59667Revert unintended change in r59666catrope16:29, 2 December 2009
r59697Revert js2stopgap to its good state before r58959 tried to prettify it and r5...catrope10:22, 3 December 2009

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:08, 2 December 2009

Wow! That's amazing. Great work Roan!

#Comment by MaxSem (talk | contribs)   08:03, 3 December 2009

Bug introduced in r58959

Status & tagging log