r56514 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56513‎ | r56514 | r56515 >
Date:14:22, 17 September 2009
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
Followup to r56174: tooltipAndAccesskey also returns a string
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1943,7 +1943,7 @@
19441944 public function tooltipAndAccesskey( $name ) {
19451945 global $wgEnableTooltipsAndAccesskeys;
19461946 if ( !$wgEnableTooltipsAndAccesskeys )
1947 - return array();
 1947+ return '';
19481948 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19491949 # no attribute" instead of "output '' as value for attribute", this
19501950 # would be three lines.

Follow-up revisions

RevisionCommit summaryAuthorDate
r56517wmf-deployment: Merge r56174 and r56514 (Linker::tooltip() fixes)catrope14:35, 17 September 2009
r60421Followup to r56514 r56174 empty strings are not NULLoverlordq23:15, 26 December 2009
r61904Revert r56514 and r60421 per CR.tstarling04:54, 3 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56174Fixes for r56068 and r55984:...ialex10:59, 11 September 2009

Comments

#Comment by Tim Starling (talk | contribs)   08:14, 12 January 2010

Umm, no it doesn't. It returns an array.

Status & tagging log