r56174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56173‎ | r56174 | r56175 >
Date:10:59, 11 September 2009
Author:ialex
Status:ok
Tags:
Comment:
Fixes for r56068 and r55984:
* missing "!" for the check $wgEnableTooltipsAndAccesskeys
* Linker::tooltip() return a string, no an array
* spacing fixes
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1942,7 +1942,7 @@
19431943 */
19441944 public function tooltipAndAccesskey( $name ) {
19451945 global $wgEnableTooltipsAndAccesskeys;
1946 - if (!$wgEnableTooltipsAndAccesskeys)
 1946+ if ( !$wgEnableTooltipsAndAccesskeys )
19471947 return array();
19481948 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19491949 # no attribute" instead of "output '' as value for attribute", this
@@ -1963,8 +1963,8 @@
19641964 /** @deprecated Returns raw bits of HTML, use titleAttrib() */
19651965 public function tooltip( $name, $options = null ) {
19661966 global $wgEnableTooltipsAndAccesskeys;
1967 - if ($wgEnableTooltipsAndAccesskeys)
1968 - return array();
 1967+ if ( !$wgEnableTooltipsAndAccesskeys )
 1968+ return '';
19691969 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19701970 # no attribute" instead of "output '' as value for attribute", this
19711971 # would be two lines.

Follow-up revisions

RevisionCommit summaryAuthorDate
r56514Followup to r56174: tooltipAndAccesskey also returns a stringcatrope14:22, 17 September 2009
r56517wmf-deployment: Merge r56174 and r56514 (Linker::tooltip() fixes)catrope14:35, 17 September 2009
r60421Followup to r56514 r56174 empty strings are not NULLoverlordq23:15, 26 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55984features time - a feature that allows to disable a feature!...midom18:38, 7 September 2009
r56068Cleanup r55984: rename new $wgDisableTooltipsAndAccesskeys to $wgEnableToolti...brion20:59, 8 September 2009

Status & tagging log