r56517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56516‎ | r56517 | r56518 >
Date:14:35, 17 September 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r56174 and r56514 (Linker::tooltip() fixes)
Modified paths:
  • /branches/wmf-deployment/includes/Linker.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/Linker.php
@@ -1942,8 +1942,8 @@
19431943 */
19441944 public function tooltipAndAccesskey( $name ) {
19451945 global $wgEnableTooltipsAndAccesskeys;
1946 - if (!$wgEnableTooltipsAndAccesskeys)
1947 - return array();
 1946+ if ( !$wgEnableTooltipsAndAccesskeys )
 1947+ return '';
19481948 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19491949 # no attribute" instead of "output '' as value for attribute", this
19501950 # would be three lines.
@@ -1963,7 +1963,7 @@
19641964 /** @deprecated Returns raw bits of HTML, use titleAttrib() */
19651965 public function tooltip( $name, $options = null ) {
19661966 global $wgEnableTooltipsAndAccesskeys;
1967 - if ($wgEnableTooltipsAndAccesskeys)
 1967+ if ( !$wgEnableTooltipsAndAccesskeys )
19681968 return '';
19691969 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19701970 # no attribute" instead of "output '' as value for attribute", this
Property changes on: branches/wmf-deployment/includes/Linker.php
___________________________________________________________________
Name: svn:mergeinfo
19711971 + /branches/REL1_15/phase3/includes/Linker.php:51646
/branches/wmf-deployment/includes/Linker.php:53381
/trunk/phase3/includes/Linker.php:56174,56213,56215-56216,56218,56334-56336,56338,56340,56343,56345,56347,56350,56514

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56174Fixes for r56068 and r55984:...ialex10:59, 11 September 2009
r56514Followup to r56174: tooltipAndAccesskey also returns a stringcatrope14:22, 17 September 2009

Status & tagging log