r56068 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56067‎ | r56068 | r56069 >
Date:20:59, 8 September 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
Cleanup r55984: rename new $wgDisableTooltipsAndAccesskeys to $wgEnableTooltipsAndAccesskeys and swap value.
'enable' settings are less confusing than 'disable' settings. :)
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1941,8 +1941,8 @@
19421942 * @deprecated Returns raw bits of HTML, use titleAttrib() and accesskey()
19431943 */
19441944 public function tooltipAndAccesskey( $name ) {
1945 - global $wgDisableTooltipsAndAccesskeys;
1946 - if ($wgDisableTooltipsAndAccesskeys)
 1945+ global $wgEnableTooltipsAndAccesskeys;
 1946+ if (!$wgEnableTooltipsAndAccesskeys)
19471947 return array();
19481948 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19491949 # no attribute" instead of "output '' as value for attribute", this
@@ -1962,8 +1962,8 @@
19631963
19641964 /** @deprecated Returns raw bits of HTML, use titleAttrib() */
19651965 public function tooltip( $name, $options = null ) {
1966 - global $wgDisableTooltipsAndAccesskeys;
1967 - if ($wgDisableTooltipsAndAccesskeys)
 1966+ global $wgEnableTooltipsAndAccesskeys;
 1967+ if ($wgEnableTooltipsAndAccesskeys)
19681968 return array();
19691969 # FIXME: If Sanitizer::expandAttributes() treated "false" as "output
19701970 # no attribute" instead of "output '' as value for attribute", this
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3464,9 +3464,11 @@
34653465 $wgDisableHardRedirects = false;
34663466
34673467 /**
3468 - * Disable tooltips and access keys
 3468+ * Set to false to disable application of access keys and tooltips,
 3469+ * eg to avoid keyboard conflicts with system keys or as a low-level
 3470+ * optimization.
34693471 */
3470 -$wgDisableTooltipsAndAccesskeys = false;
 3472+$wgEnableTooltipsAndAccesskeys = true;
34713473
34723474 /**
34733475 * Use http.dnsbl.sorbs.net to check for open proxies

Follow-up revisions

RevisionCommit summaryAuthorDate
r56174Fixes for r56068 and r55984:...ialex10:59, 11 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55984features time - a feature that allows to disable a feature!...midom18:38, 7 September 2009

Comments

#Comment by Midom (talk | contribs)   21:02, 8 September 2009

okok :-)

Status & tagging log