r54585 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r54584‎ | r54585 | r54586 >
Date:16:06, 7 August 2009
Author:werdna
Status:reverted
Tags:
Comment:
Fix bug 19261 by saving the username as the signature if it is submitted empty
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
——@@ -1121,6 +1121,9 @@
11221122 // When no fancy sig used, make sure ~{3,5} get removed.
11231123 $signature = $wgParser->cleanSigInSig( $signature );
11241124 }
 1125+
 1126+ global $wgUser;
 1127+ if (!$signature) $signature = $wgUser->getName();
11251128
11261129 return $signature;
11271130 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r55306Revert r54585 "Fix bug 19261 by saving the username as the signature if it is...brion02:33, 19 August 2009
r56102Relax === check for blank signatures to ==, fixes bug 19261 (alternative solu...werdna17:30, 9 September 2009

Status & tagging log