r54586 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54585‎ | r54586 | r54587 >
Date:16:13, 7 August 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix bug 19799, hide public versions of private filters.
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewEdit.php
@@ -239,7 +239,9 @@
240240 $wgOut->setSubtitle( wfMsg( 'abusefilter-edit-subtitle', $filter, $history_id ) );
241241
242242 // Hide hidden filters.
243 - if ( isset($row->af_hidden) && $row->af_hidden && !$this->canViewPrivate() ) {
 243+ if ( ( (isset($row->af_hidden) && $row->af_hidden) ||
 244+ AbuseFilter::filterHidden( $filter ) )
 245+ && !$this->canViewPrivate() ) {
244246 return wfMsg( 'abusefilter-edit-denied' );
245247 }
246248

Follow-up revisions

RevisionCommit summaryAuthorDate
r54588Updating HoneypotIntegration extension to trunk (@r54586) in prep for deploym...werdna16:18, 7 August 2009

Status & tagging log