r55306 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55305‎ | r55306 | r55307 >
Date:02:33, 19 August 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r54585 "Fix bug 19261 by saving the username as the signature if it is submitted empty"

Looks like the base problem is that empty is being interpreted as "put empty in the sig" instead of as "use default sig" at signature replacement time.
We shouldn't be saving the username into preferences if it hasn't been explicitly typed; if the user changes their name, they should automatically pick up the new value.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
——@@ -1121,9 +1121,6 @@
11221122 // When no fancy sig used, make sure ~{3,5} get removed.
11231123 $signature = $wgParser->cleanSigInSig( $signature );
11241124 }
1125 -
1126 - global $wgUser;
1127 - if (!$signature) $signature = $wgUser->getName();
11281125
11291126 return $signature;
11301127 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r56102Relax === check for blank signatures to ==, fixes bug 19261 (alternative solu...werdna17:30, 9 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54585Fix bug 19261 by saving the username as the signature if it is submitted emptywerdna16:06, 7 August 2009

Status & tagging log