r56102 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56101‎ | r56102 | r56103 >
Date:17:30, 9 September 2009
Author:werdna
Status:ok
Tags:
Comment:
Relax === check for blank signatures to ==, fixes bug 19261 (alternative solution to r54585)
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -3926,7 +3926,7 @@
39273927
39283928 $username = $user->getName();
39293929 $nickname = $user->getOption( 'nickname' );
3930 - $nickname = $nickname === null ? $username : $nickname;
 3930+ $nickname = $nickname == null ? $username : $nickname;
39313931
39323932 if( mb_strlen( $nickname ) > $wgMaxSigChars ) {
39333933 $nickname = $username;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54585Fix bug 19261 by saving the username as the signature if it is submitted emptywerdna16:06, 7 August 2009
r55306Revert r54585 "Fix bug 19261 by saving the username as the signature if it is...brion02:33, 19 August 2009

Status & tagging log