r51320 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51319‎ | r51320 | r51321 >
Date:22:51, 1 June 2009
Author:purodha
Status:deferred
Tags:
Comment:
Message 'configure-viewconfig-line' - date and time separated as cwsuggeste by user "Der Umherirrende" at
http://translatewiki.net/w/i.php?title=Support&oldid=1243738#split_date_and_time ,
and user name parameter added, when available, for GENDER use.
Modified paths:
  • /trunk/extensions/Configure/Configure.i18n.php (modified) (history)
  • /trunk/extensions/Configure/SpecialViewConfig.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialViewConfig.php
@@ -175,19 +175,26 @@
176176 $hasSelf = in_array( $this->mWiki, $wikis );
177177
178178 extract( $this->formatConf );
179 - $time = $wgLang->timeAndDate( $ts );
 179+ $datim = $wgLang->timeAndDate( $ts );
 180+ $date = $wgLang->date( $ts );
 181+ $time = $wgLang->time( $ts );
180182
181183 ## Make user link...
182184 $userLink = '';
 185+ $user = '';
183186 if (!$arr['user_wiki'] && !$arr['user_name'] ) {
184187 $userLink = ''; # Nothing...
 188+ $user = ''; # Nothing...
185189 } elseif ( $arr['user_wiki'] == wfWikiId() ) {
186190 $userLink = $skin->link( Title::makeTitle( NS_USER, $arr['user_name'] ), $arr['user_name'] );
 191+ $user = $arr['user_name'];
187192 } elseif ( class_exists( 'WikiMap' ) && ($wiki = WikiMap::getWiki( $arr['user_wiki'] ) ) ) {
188193 $userLink = $skin->makeExternalLink( $wiki->getUrl( 'User:'.$arr['user_name'] ), $arr['user_name'].'@'.$arr['user_wiki'] );
 194+ $user = ''; # Nothing...
189195 } else {
190196 ## Last-ditch
191197 $userLink = $arr['user_name'].'@'.$arr['user_wiki'];
 198+ $user = ''; # Nothing...
192199 }
193200
194201 $actions = array();
@@ -263,7 +270,7 @@
264271 $comment = $arr['reason'] ? $skin->commentBlock( $arr['reason'] ) : '';
265272
266273 $action = $wgLang->commaList( $actions );
267 - return Xml::tags( 'li', null, wfMsgExt( 'configure-viewconfig-line', array( 'parseinline', 'replaceafter' ), array( $buttons, $time, $userLink, $action, $comment ) ) )."\n";
 274+ return Xml::tags( 'li', null, wfMsgExt( 'configure-viewconfig-line', array( 'parseinline', 'replaceafter' ), array( $buttons, $datim, $userLink, $action, $comment, $date, $time, $user ) ) )."\n";
268275 }
269276
270277 /**
Index: trunk/extensions/Configure/Configure.i18n.php
@@ -279,11 +279,14 @@
280280 'configure-transwiki-not-in-range' => '* $1 is the wiki, as given by the user
281281 * $2 is the list of allowed wikis
282282 * $3 is the number of items in $2',
283 - 'configure-viewconfig-line' => '* $1 will be replaced with two radio buttons, as in history pages
 283+ 'configure-viewconfig-line' => '* $1 may be two radio buttons, as in history pages, or empty
284284 * $2 is the time and date of the version
285 -* $3 is the user who made the version
286 -* $4 will be replaced with links to that version
287 -* $5 is the comment, as provided by the user',
 285+* $3 is a link to the user who made the version, or a text, or empty
 286+* $4 will be replaced with zero to several links to that version
 287+* $5 is the comment, as provided by the user, which may be empty
 288+* $6 is the date of the version
 289+* $7 is the time of the version
 290+* $8 is the name of the user who made version, or empty',
288291 'extensions' => 'Name of special page displayed in [[Special:SpecialPages]].',
289292 'right-configure' => '{{doc-right}}',
290293 'right-configure-all' => '{{doc-right}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r51330Revert part of r51320: removed user parameter for GENDER ($8): it will simply...ialex07:04, 2 June 2009

Status & tagging log