r51330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51329‎ | r51330 | r51331 >
Date:07:04, 2 June 2009
Author:ialex
Status:deferred
Tags:
Comment:
Revert part of r51320: removed user parameter for GENDER ($8): it will simply not work since parameters are replaced *after* parsing
Modified paths:
  • /trunk/extensions/Configure/Configure.i18n.php (modified) (history)
  • /trunk/extensions/Configure/SpecialViewConfig.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialViewConfig.php
@@ -181,20 +181,15 @@
182182
183183 ## Make user link...
184184 $userLink = '';
185 - $user = '';
186185 if (!$arr['user_wiki'] && !$arr['user_name'] ) {
187186 $userLink = ''; # Nothing...
188 - $user = ''; # Nothing...
189187 } elseif ( $arr['user_wiki'] == wfWikiId() ) {
190188 $userLink = $skin->link( Title::makeTitle( NS_USER, $arr['user_name'] ), $arr['user_name'] );
191 - $user = $arr['user_name'];
192189 } elseif ( class_exists( 'WikiMap' ) && ($wiki = WikiMap::getWiki( $arr['user_wiki'] ) ) ) {
193190 $userLink = $skin->makeExternalLink( $wiki->getUrl( 'User:'.$arr['user_name'] ), $arr['user_name'].'@'.$arr['user_wiki'] );
194 - $user = ''; # Nothing...
195191 } else {
196192 ## Last-ditch
197193 $userLink = $arr['user_name'].'@'.$arr['user_wiki'];
198 - $user = ''; # Nothing...
199194 }
200195
201196 $actions = array();
@@ -270,7 +265,7 @@
271266 $comment = $arr['reason'] ? $skin->commentBlock( $arr['reason'] ) : '';
272267
273268 $action = $wgLang->commaList( $actions );
274 - return Xml::tags( 'li', null, wfMsgExt( 'configure-viewconfig-line', array( 'parseinline', 'replaceafter' ), array( $buttons, $datim, $userLink, $action, $comment, $date, $time, $user ) ) )."\n";
 269+ return Xml::tags( 'li', null, wfMsgExt( 'configure-viewconfig-line', array( 'parseinline', 'replaceafter' ), array( $buttons, $datim, $userLink, $action, $comment, $date, $time ) ) )."\n";
275270 }
276271
277272 /**
Index: trunk/extensions/Configure/Configure.i18n.php
@@ -285,8 +285,7 @@
286286 * $4 will be replaced with zero to several links to that version
287287 * $5 is the comment, as provided by the user, which may be empty
288288 * $6 is the date of the version
289 -* $7 is the time of the version
290 -* $8 is the name of the user who made version, or empty',
 289+* $7 is the time of the version',
291290 'extensions' => 'Name of special page displayed in [[Special:SpecialPages]].',
292291 'right-configure' => '{{doc-right}}',
293292 'right-configure-all' => '{{doc-right}}',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51320Message 'configure-viewconfig-line' - date and time separated as cwsuggeste b...purodha22:51, 1 June 2009

Status & tagging log