r51321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51320‎ | r51321 | r51322 >
Date:23:15, 1 June 2009
Author:purodha
Status:ok
Tags:
Comment:
Message 'abusefilter-edit-lastmod-text' - date and time separated as of request by user "Der Umherirrende" at
http://translatewiki.net/w/i.php?title=Support&oldid=1243738#split_date_and_time
and user name added for GENDER use.
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.i18n.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewEdit.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php
@@ -255,10 +255,15 @@
256256 $row->af_user,
257257 $row->af_user_text
258258 );
 259+ $user = $row->af_user_text;
259260 return wfMsgExt(
260261 'abusefilter-edit-lastmod-text',
261262 array( 'replaceafter', 'parseinline' ),
262 - array( $wgLang->timeanddate( $value, true ), $userLink )
 263+ array( $wgLang->timeanddate( $value, true ),
 264+ $userLink,
 265+ $wgLang->date( $value, true ),
 266+ $wgLang->time( $value, true ),
 267+ $user )
263268 );
264269 default:
265270 throw new MWException( "Unknown row type $name!" );
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewEdit.php
@@ -348,14 +348,19 @@
349349 )
350350 );
351351 // Last modification details
352 - $user =
 352+ $userLink =
353353 $sk->userLink( $row->af_user, $row->af_user_text ) .
354354 $sk->userToolLinks( $row->af_user, $row->af_user_text );
 355+ $user = $row->af_user_text;
355356 $fields['abusefilter-edit-lastmod'] =
356357 wfMsgExt(
357358 'abusefilter-edit-lastmod-text',
358359 array( 'parseinline', 'replaceafter' ),
359 - array( $wgLang->timeanddate( $row->af_timestamp, true ), $user )
 360+ array( $wgLang->timeanddate( $row->af_timestamp, true ),
 361+ $userLink,
 362+ $wgLang->date( $row->af_timestamp, true ),
 363+ $wgLang->time( $row->af_timestamp, true ),
 364+ $user )
360365 );
361366 $history_display = wfMsgExt( 'abusefilter-edit-viewhistory', array( 'parseinline' ) );
362367 $fields['abusefilter-edit-history'] =
Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
@@ -530,8 +530,11 @@
531531 'abusefilter-edit-status-label' => '{{Identical|Statistics}}',
532532 'abusefilter-edit-id' => '{{Identical|Filter ID}}',
533533 'abusefilter-edit-lastmod-text' => 'This message is used on Special:AbuseFilter to indicate the last modified date, time and user for existing rules.
534 -* $1 is a time and date
535 -* $2 is a link to a user page with a user name as link text',
 534+* $1 is a time and date (duplicated in $3 and $4)
 535+* $2 is a link to a user page with a user name as link text, followed by a series of related links
 536+* $3 is the date
 537+* $4 is the time
 538+* $5 is the user name which can be used with GENDER',
536539 'abusefilter-edit-history' => '{{Identical|History}}',
537540 'abusefilter-edit-builder-misc-in' => 'Do not translate "(in)"',
538541 'abusefilter-edit-builder-misc-like' => 'Do not translate "(like)"',

Status & tagging log