r49856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49855‎ | r49856 | r49857 >
Date:05:19, 25 April 2009
Author:philip
Status:ok
Tags:
Comment:
Use $wgContLang->convertHtml() instead of htmlspecialchars().
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTreeFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/CategoryTreeFunctions.php
@@ -617,11 +617,9 @@
618618
619619 #when showing only categories, omit namespace in label unless we explicitely defined the configuration setting
620620 #patch contributed by Manuel Schneider <manuel.schneider@wikimedia.ch>, Bug 8011
621 - if ( $hideprefix ) $label = htmlspecialchars( $title->getText() );
622 - else $label = htmlspecialchars( $title->getPrefixedText() );
 621+ if ( $hideprefix ) $label = $wgContLang->convertHtml( $title->getText(), true );
 622+ else $label = $wgContLang->convertHtml( $title->getPrefixedText(), true );
623623
624 - $label = $wgContLang->convert( $label, true );
625 -
626624 if ( $trans && $trans!=$label ) $label.= ' ' . Xml::element( 'i', array( 'class' => 'translation'), $trans );
627625
628626 $labelClass = 'CategoryTreeLabel ' . ' CategoryTreeLabelNs' . $ns;

Follow-up revisions

RevisionCommit summaryAuthorDate
r51048Fixed r51002 by also reverting r49856.tstarling06:17, 27 May 2009

Status & tagging log