r49855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49854‎ | r49855 | r49856 >
Date:05:13, 25 April 2009
Author:philip
Status:reverted (Comments)
Tags:
Comment:
Enabled LanguageConverter on extension:CategoryTree.
Convert title text displayed in Category with title mode.
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTreeFunctions.php (modified) (history)
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -189,7 +189,7 @@
190190 */
191191 function addPage( $title, $sortkey, $pageLength, $isRedirect = false ) {
192192 global $wgContLang;
193 - $titletext = $wgContLang->convertHtml( $title->getPrefixedText() );
 193+ $titletext = $wgContLang->convertHtml( $title->getPrefixedText(), true );
194194 $this->articles[] = $isRedirect
195195 ? '<span class="redirect-in-category">' . $this->getSkin()->makeKnownLinkObj( $title, $titletext ) . '</span>'
196196 : $this->getSkin()->makeSizeLinkObj( $pageLength, $title, $titletext );
Index: trunk/extensions/CategoryTree/CategoryTreeFunctions.php
@@ -588,6 +588,7 @@
589589 * $info must be an associative array, containing at least a Title object under the 'title' key.
590590 */
591591 function renderNodeInfo( $title, $cat, $children = 0, $loadchildren = false ) {
 592+ global $wgContLang;
592593 static $uniq = 0;
593594
594595 $this->init(); # initialize messages
@@ -619,6 +620,8 @@
620621 if ( $hideprefix ) $label = htmlspecialchars( $title->getText() );
621622 else $label = htmlspecialchars( $title->getPrefixedText() );
622623
 624+ $label = $wgContLang->convert( $label, true );
 625+
623626 if ( $trans && $trans!=$label ) $label.= ' ' . Xml::element( 'i', array( 'class' => 'translation'), $trans );
624627
625628 $labelClass = 'CategoryTreeLabel ' . ' CategoryTreeLabelNs' . $ns;

Follow-up revisions

RevisionCommit summaryAuthorDate
r51002Reverted r49855, r49656, r49401, r49399, r49397. The language converter canno...tstarling07:46, 26 May 2009

Comments

#Comment by Tim Starling (talk | contribs)   08:57, 19 May 2009

Probably broken, same as r49399/r49656

Status & tagging log