r51048 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51047‎ | r51048 | r51049 >
Date:06:17, 27 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Fixed r51002 by also reverting r49856.
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTreeFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/CategoryTreeFunctions.php
@@ -616,9 +616,11 @@
617617
618618 #when showing only categories, omit namespace in label unless we explicitely defined the configuration setting
619619 #patch contributed by Manuel Schneider <manuel.schneider@wikimedia.ch>, Bug 8011
620 - if ( $hideprefix ) $label = $wgContLang->convertHtml( $title->getText(), true );
621 - else $label = $wgContLang->convertHtml( $title->getPrefixedText(), true );
 620+ if ( $hideprefix ) $label = htmlspecialchars( $title->getText() );
 621+ else $label = htmlspecialchars( $title->getPrefixedText() );
622622
 623+ $label = $wgContLang->convert( $label, true );
 624+
623625 if ( $trans && $trans!=$label ) $label.= ' ' . Xml::element( 'i', array( 'class' => 'translation'), $trans );
624626
625627 $labelClass = 'CategoryTreeLabel ' . ' CategoryTreeLabelNs' . $ns;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49856Use $wgContLang->convertHtml() instead of htmlspecialchars().philip05:19, 25 April 2009
r51002Reverted r49855, r49656, r49401, r49399, r49397. The language converter canno...tstarling07:46, 26 May 2009

Status & tagging log