r49790 MediaWiki - Code Review archive

The skin tab shows link to "(Custom CSS) (Custom JS)" for every skin instead of the currently used skin.

Doesn't seem to be a regression.

Sorry, you are right, but I could swear ... *shrugs*

More FIXMEs:

At the edit tab: missing the message 'prefs-edit-boxsize'

At the watchlist tab: missing the messages 'prefs-watchlist-days-max', 'prefs-watchlist-edits-max'

At the recent changes tab: missing the message 'recentchangesdays-max'

I don't understand this comment.

The watchlist and RC tabs seem to be ok. However, on the edit tab, there's no indication of what "rows" and "columns" means.

I mean the red bordered messages. These are indications to the user for the maximum allowed values.

bugzilla:18595: Quickbar has disappeared in Cologneblue and Standard skins

bugzilla:18580: New preferences page does not contain e-mail confirmation data

bugzilla:18581: Enable e-mail from other users setting not displayed correctly

bugzilla:18603 Link to Special:ChangePassword has disappeared from Special:Preferences tab User Profile

WFM

All reported bugs fixed, except as noted above. Please report any other regressions or bugs.

TODO for discussion with Brion:

1/ Weird spacing on gadgets and skin 2/ Renaming properties to options 3/ Warning about changing mail 4/ Investigate centralauth not being able to save email 5/ we now have too many tabs, re-merge them (email status and options are no longer visible on same screen as email; need to be re-combined)

3, 4 and 5 fixed. Still need to look at 1 and 2.

Everything done except the rename. Remaining references to 'properties' are the DB tables, seems like a bad idea to rename them considering this will be live on some sites now. (Although it can probably be done with DB updates if it's really necessary)

06:25 < wikibugs> (NEW) Image and thumbsize reset to defaults in the new preferences - https://bugzilla.wikimedia.org/show_bug.cgi?id=18605 minor; Normal; MediaWiki: User preferences;

                 (niklas.laxstrom)

• Reports that the email confirmation thing is coming up all the time.
• Sectionise
• Gray out email options

Nothing pending on this, please let me know if there is.

$user->encodeOptions() used but doesn't exist

That should be fixed in r51340.

And more fixmes:

• bug 18870: The toggle defined in $extraUserToggles won't display in the user preferences

Preferences rewrite has been deployed for a long time :)