r49826 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49825‎ | r49826 | r49827 >
Date:18:26, 24 April 2009
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Updates preferences handling to work with r49790 and up. Please review
* took out wfTasksAddCache
* needs work. Extension appears to be very outdated
Modified paths:
  • /trunk/extensions/Tasks/Tasks.i18n.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Tasks/Tasks.i18n.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 /**
54 * Translations of Tasks extension.
65 *
@@ -12,79 +11,79 @@
1312 * @author Magnus Manske
1413 */
1514 $messages['en'] = array(
16 - 'tasks' => 'Tasks',
17 - 'tasks_desc' => 'An extension to manage tasks',
18 - 'tasks_tab' => 'Tasks',
19 - 'tasks_title' => "Tasks for \"$1\"",
20 - 'tasks_form_new' => "Create new task",
21 - 'tasks_form_comment' => "Comment",
22 - 'tasks_error1' => "Task was not created: there is already such a task!",
23 - 'tasks_ok1' => "New task has been created!",
24 - 'tasks_create_header' => "Create a new task",
25 - 'tasks_existing_header' => "Existing tasks",
26 - 'tasks_existing_table_header' => "Task|Dates|Initial comment|Assignment/Actions/Page",
27 - 'tasks_noone' => "no one",
28 - 'tasks_assign_me' => "Assign myself",
29 - 'tasks_assign_to' => "Assign to",
30 - 'tasks_unassign_me' => "Remove my assignment",
31 - 'tasks_close' => "Close task",
32 - 'tasks_wontfix' => "Won't fix",
33 - 'tasks_delete' => "Delete",
34 - 'tasks_no_task_delete_title' => "Not allowed",
35 - 'tasks_no_task_delete_texe' => "You are not allowed to delete a task. Only admins can do that.",
36 - 'tasks_action_delete' => "A task was deleted.",
37 - 'tasks_task_was_deleted' => "The task was successfully deleted.",
38 - 'tasks_reopen' => "Reopen task",
39 - 'tasks_assignedto' => "Assigned to $1",
40 - 'tasks_created_by' => "Created by $1",
41 - 'tasks_discussion_page_link' => "Task discussion page",
42 - 'tasks_closedby' => "Closed by $1",
43 - 'tasks_assigned_myself_log' => "Self-assignment of task \"$1\"",
44 - 'tasks_discussion_page_for' => "This task is for the page \"$1\". The list of all tasks for that page is $2.",
45 - 'tasks_sidebar_title' => "Open tasks",
46 - 'tasks_here' => "here",
47 - 'tasks_returnto' => "You will be redirected now. If you have not been redirected in a few seconds, click $1.",
48 - 'tasks_see_page_tasks' => "(tasks of this page)",
49 - 'tasks_task_is_assigned' => "(assigned)",
50 - 'tasks_plain_text_only' => "(plain text, 256 chars only)",
51 - 'tasks_help_page' => "Tasks",
52 - 'tasks_help_page_link' => "?", # only translate this message to other languages if you have to change it
53 - 'tasks_help_separator' => "$2{{int:pipe-separator}}$1", # do not translate or duplicate this message to other languages
54 - 'tasks_more_like_it' => "more",
55 - 'tasks_task_types' => "1:cleanup:Cleanup|2:wikify:Wikify|3:rewrite:Rewrite|4:delete:Delete|5:create:Create|6:write:Write|7:check:Check",
56 - 'tasks_significance_order' => "rewrite<delete", # do not translate or duplicate this message to other languages
57 - 'tasks_creation_tasks' => "5,6", # do not translate or duplicate this message to other languages
58 - 'tasks_event_on_creation' => "check",
59 - 'tasks_event_on_creation_anon' => "check",
60 - 'tasks_on_creation_comment' => "Automatic task, generated on page creation",
61 - 'tasks_link_your_assignments' => "open assignments",
62 - 'tasks_see_your_assignments' => "You currently have $1 open {{PLURAL:$1|assignment|assignments}}. See your $2.",
63 - 'tasks_my_assignments' => "Your current {{PLURAL:$1|assignment|assignments}}",
64 - 'tasks_table_header_page' => "Page",
65 - 'tasks_you_have_no_assignments' => "You have no open assignments",
66 - 'tasks_search_form_title' => "Search",
67 - 'tasks_search_tasks' => "Tasks",
68 - 'tasks_search_status' => "Status",
69 - 'tasks_search_no_tasks_chosen_note' => "(No selection here will search all task types.)",
70 - 'tasks_search_results' => "Search results",
71 - 'tasks_previous' => "Previous",
72 - 'tasks_next' => "Next",
73 - 'tasks_sort' => "Sort",
74 - 'tasks_ascending' => "Oldest first",
75 - 'tasks_search_limit' => "10",
76 - 'tasks_status_open' => "Open",
77 - 'tasks_status_assigned' => "Assigned",
78 - 'tasks_status_closed' => "Closed",
79 - 'tasks_status_wontfix' => "Won't fix",
80 - 'tasks_action_open' => "Task \"$1\" opened.",
81 - 'tasks_action_assigned' => "Task \"$1\" assigned.",
82 - 'tasks_action_closed' => "Task \"$1\" closed.",
83 - 'tasks_action_wontfix' => "Won't fix task \"$1\".",
84 - 'tasks_sign_delete' => "<b>It has been asked to delete this page!</b>",
85 - 'tasks_logpage' => "Tasks log",
86 - 'tasks_logpagetext' => 'This is a log of changes to tasks',
87 - 'tasks_logentry' => 'For "[[$1]]"',
88 - 'tog-show_task_comments' => 'Transclude task comments page.',
 15+ 'tasks' => 'Tasks',
 16+ 'tasks_desc' => 'An extension to manage tasks',
 17+ 'tasks_tab' => 'Tasks',
 18+ 'tasks_title' => "Tasks for \"$1\"",
 19+ 'tasks_form_new' => "Create new task",
 20+ 'tasks_form_comment' => "Comment",
 21+ 'tasks_error1' => "Task was not created: there is already such a task!",
 22+ 'tasks_ok1' => "New task has been created!",
 23+ 'tasks_create_header' => "Create a new task",
 24+ 'tasks_existing_header' => "Existing tasks",
 25+ 'tasks_existing_table_header' => "Task|Dates|Initial comment|Assignment/Actions/Page",
 26+ 'tasks_noone' => "no one",
 27+ 'tasks_assign_me' => "Assign myself",
 28+ 'tasks_assign_to' => "Assign to",
 29+ 'tasks_unassign_me' => "Remove my assignment",
 30+ 'tasks_close' => "Close task",
 31+ 'tasks_wontfix' => "Won't fix",
 32+ 'tasks_delete' => "Delete",
 33+ 'tasks_no_task_delete_title' => "Not allowed",
 34+ 'tasks_no_task_delete_texe' => "You are not allowed to delete a task. Only admins can do that.",
 35+ 'tasks_action_delete' => "A task was deleted.",
 36+ 'tasks_task_was_deleted' => "The task was successfully deleted.",
 37+ 'tasks_reopen' => "Reopen task",
 38+ 'tasks_assignedto' => "Assigned to $1",
 39+ 'tasks_created_by' => "Created by $1",
 40+ 'tasks_discussion_page_link' => "Task discussion page",
 41+ 'tasks_closedby' => "Closed by $1",
 42+ 'tasks_assigned_myself_log' => "Self-assignment of task \"$1\"",
 43+ 'tasks_discussion_page_for' => "This task is for the page \"$1\". The list of all tasks for that page is $2.",
 44+ 'tasks_sidebar_title' => "Open tasks",
 45+ 'tasks_here' => "here",
 46+ 'tasks_returnto' => "You will be redirected now. If you have not been redirected in a few seconds, click $1.",
 47+ 'tasks_see_page_tasks' => "(tasks of this page)",
 48+ 'tasks_task_is_assigned' => "(assigned)",
 49+ 'tasks_plain_text_only' => "(plain text, 256 chars only)",
 50+ 'tasks_help_page' => "Tasks",
 51+ 'tasks_help_page_link' => "?", # only translate this message to other languages if you have to change it
 52+ 'tasks_help_separator' => "$2{{int:pipe-separator}}$1", # do not translate or duplicate this message to other languages
 53+ 'tasks_more_like_it' => "more",
 54+ 'tasks_task_types' => "1:cleanup:Cleanup|2:wikify:Wikify|3:rewrite:Rewrite|4:delete:Delete|5:create:Create|6:write:Write|7:check:Check",
 55+ 'tasks_significance_order' => "rewrite<delete", # do not translate or duplicate this message to other languages
 56+ 'tasks_creation_tasks' => "5,6", # do not translate or duplicate this message to other languages
 57+ 'tasks_event_on_creation' => "check",
 58+ 'tasks_event_on_creation_anon' => "check",
 59+ 'tasks_on_creation_comment' => "Automatic task, generated on page creation",
 60+ 'tasks_link_your_assignments' => "open assignments",
 61+ 'tasks_see_your_assignments' => "You currently have $1 open {{PLURAL:$1|assignment|assignments}}. See your $2.",
 62+ 'tasks_my_assignments' => "Your current {{PLURAL:$1|assignment|assignments}}",
 63+ 'tasks_table_header_page' => "Page",
 64+ 'tasks_you_have_no_assignments' => "You have no open assignments",
 65+ 'tasks_search_form_title' => "Search",
 66+ 'tasks_search_tasks' => "Tasks",
 67+ 'tasks_search_status' => "Status",
 68+ 'tasks_search_no_tasks_chosen_note' => "(No selection here will search all task types.)",
 69+ 'tasks_search_results' => "Search results",
 70+ 'tasks_previous' => "Previous",
 71+ 'tasks_next' => "Next",
 72+ 'tasks_sort' => "Sort",
 73+ 'tasks_ascending' => "Oldest first",
 74+ 'tasks_search_limit' => "10",
 75+ 'tasks_status_open' => "Open",
 76+ 'tasks_status_assigned' => "Assigned",
 77+ 'tasks_status_closed' => "Closed",
 78+ 'tasks_status_wontfix' => "Won't fix",
 79+ 'tasks_action_open' => "Task \"$1\" opened.",
 80+ 'tasks_action_assigned' => "Task \"$1\" assigned.",
 81+ 'tasks_action_closed' => "Task \"$1\" closed.",
 82+ 'tasks_action_wontfix' => "Won't fix task \"$1\".",
 83+ 'tasks_sign_delete' => "<b>It has been asked to delete this page!</b>",
 84+ 'tasks_logpage' => "Tasks log",
 85+ 'tasks_logpagetext' => 'This is a log of changes to tasks',
 86+ 'tasks_logentry' => 'For "[[$1]]"',
 87+ 'tasks-pref-showtaskcomments' => 'Transclude task comments page.',
8988 );
9089
9190 /** Message documentation (Message documentation)
@@ -199,7 +198,7 @@
200199 'tasks_logpage' => 'سجل المهام',
201200 'tasks_logpagetext' => 'هذا سجل لتغييرات المهام',
202201 'tasks_logentry' => 'لأجل [[$1]]',
203 - 'tog-show_task_comments' => 'ضمن صفحة تعليقات المهمة.',
 202+ 'tasks-pref-showtaskcomments' => 'ضمن صفحة تعليقات المهمة.',
204203 );
205204
206205 /** Egyptian Spoken Arabic (مصرى)
@@ -276,7 +275,7 @@
277276 'tasks_logpage' => 'سجل المهام',
278277 'tasks_logpagetext' => 'هذا سجل لتغييرات المهام',
279278 'tasks_logentry' => 'لأجل [[$1]]',
280 - 'tog-show_task_comments' => 'ضمن صفحة تعليقات المهمة.',
 279+ 'tasks-pref-showtaskcomments' => 'ضمن صفحة تعليقات المهمة.',
281280 );
282281
283282 /** Belarusian (Taraškievica orthography) (Беларуская (тарашкевіца))
@@ -352,7 +351,7 @@
353352 'tasks_logpage' => 'Журнал заданьняў',
354353 'tasks_logpagetext' => 'Гэта журнал зьменаў заданьняў',
355354 'tasks_logentry' => 'Для «[[$1]]»',
356 - 'tog-show_task_comments' => 'Далучыць старонку камэнтараў заданьня.',
 355+ 'tasks-pref-showtaskcomments' => 'Далучыць старонку камэнтараў заданьня.',
357356 );
358357
359358 /** Bulgarian (Български)
@@ -464,7 +463,7 @@
465464 'tasks_logpage' => 'Zapisnik zadataka',
466465 'tasks_logpagetext' => 'Ovo je zapisnik promjena u zadacima',
467466 'tasks_logentry' => 'za "[[$1]]"',
468 - 'tog-show_task_comments' => 'Uključivanje stranice komentara zadatka.',
 467+ 'tasks-pref-showtaskcomments' => 'Uključivanje stranice komentara zadatka.',
469468 );
470469
471470 /** Czech (Česky)
@@ -537,7 +536,7 @@
538537 'tasks_logpage' => 'Seznam úkolů',
539538 'tasks_logpagetext' => 'Toto je seznam změn v úkolech',
540539 'tasks_logentry' => 'Pro „[[$1]]“',
541 - 'tog-show_task_comments' => 'Vložení diskusní stránky úkolu.',
 540+ 'tasks-pref-showtaskcomments' => 'Vložení diskusní stránky úkolu.',
542541 );
543542
544543 /** German (Deutsch)
@@ -619,7 +618,7 @@
620619 'tasks_logpage' => 'Aufgaben-Logbuch',
621620 'tasks_logpagetext' => 'Dieses Logbuch protokolliert Änderungen an Aufgaben.',
622621 'tasks_logentry' => 'für „[[$1]]“',
623 - 'tog-show_task_comments' => 'Aufgaben-Diskussionsseite einbinden.',
 622+ 'tasks-pref-showtaskcomments' => 'Aufgaben-Diskussionsseite einbinden.',
624623 );
625624
626625 /** German (formal address) (Deutsch (Sie-Form))
@@ -705,7 +704,7 @@
706705 'tasks_logpage' => 'Protokol nadawkow',
707706 'tasks_logpagetext' => 'To jo protokol změnow k nadawkam',
708707 'tasks_logentry' => 'Za "[[$1]]"',
709 - 'tog-show_task_comments' => 'Bok za nadawkowe komentary zapśěgnuś',
 708+ 'tasks-pref-showtaskcomments' => 'Bok za nadawkowe komentary zapśěgnuś',
710709 );
711710
712711 /** Greek (Ελληνικά)
@@ -808,7 +807,7 @@
809808 'tasks_logpage' => 'Protokolo de taskoj',
810809 'tasks_logpagetext' => 'Jen protokolo de ŝanĝoj al taskoj',
811810 'tasks_logentry' => 'Por "[[$1]]"',
812 - 'tog-show_task_comments' => 'Transinkluzivi paĝon de taskaj komentoj.',
 811+ 'tasks-pref-showtaskcomments' => 'Transinkluzivi paĝon de taskaj komentoj.',
813812 );
814813
815814 /** Spanish (Español)
@@ -1009,7 +1008,7 @@
10101009 'tasks_logpage' => 'Historique des tâches',
10111010 'tasks_logpagetext' => 'Ceci est un historique des changements dans les tâches',
10121011 'tasks_logentry' => 'Pour « [[$1]] »',
1013 - 'tog-show_task_comments' => 'Voir la page de commentaires à propos des tâches.',
 1012+ 'tasks-pref-showtaskcomments' => 'Voir la page de commentaires à propos des tâches.',
10141013 );
10151014
10161015 /** Galician (Galego)
@@ -1083,7 +1082,7 @@
10841083 'tasks_logpage' => 'Rexistro de tarefas',
10851084 'tasks_logpagetext' => 'Este é un rexistro dos cambios feitos nas tarefas',
10861085 'tasks_logentry' => 'De "[[$1]]"',
1087 - 'tog-show_task_comments' => 'Páxina de comentarios das tarefas.',
 1086+ 'tasks-pref-showtaskcomments' => 'Páxina de comentarios das tarefas.',
10881087 );
10891088
10901089 /** Ancient Greek (Ἀρχαία ἑλληνικὴ)
@@ -1174,7 +1173,7 @@
11751174 'tasks_logpage' => 'Ufgabe-Logbuech',
11761175 'tasks_logpagetext' => 'In däm Logbuech stehn d Änderige an Ufgabe.',
11771176 'tasks_logentry' => 'Fir „[[$1]]“',
1178 - 'tog-show_task_comments' => 'Ufgabe-Diskussionssyte yybinde.',
 1177+ 'tasks-pref-showtaskcomments' => 'Ufgabe-Diskussionssyte yybinde.',
11791178 );
11801179
11811180 /** Hawaiian (Hawai`i)
@@ -1256,7 +1255,7 @@
12571256 'tasks_logpage' => 'יומן משימות',
12581257 'tasks_logpagetext' => 'יומן זה מציג את השינויים במשימות',
12591258 'tasks_logentry' => 'עבור "[[$1]]"',
1260 - 'tog-show_task_comments' => 'הכללת דף השיחה של המשימה.',
 1259+ 'tasks-pref-showtaskcomments' => 'הכללת דף השיחה של המשימה.',
12611260 );
12621261
12631262 /** Upper Sorbian (Hornjoserbsce)
@@ -1330,7 +1329,7 @@
13311330 'tasks_logpage' => 'Protokol nadawkow',
13321331 'tasks_logpagetext' => 'To je protokol změnow za nadawki',
13331332 'tasks_logentry' => 'Za "[[$1]]"',
1334 - 'tog-show_task_comments' => 'Komentarowu stronu nadawkow zapřijeć',
 1333+ 'tasks-pref-showtaskcomments' => 'Komentarowu stronu nadawkow zapřijeć',
13351334 );
13361335
13371336 /** Interlingua (Interlingua)
@@ -1404,7 +1403,7 @@
14051404 'tasks_logpage' => 'Registro de cargas',
14061405 'tasks_logpagetext' => 'Isto es un registro de cambiamentos in le cargas',
14071406 'tasks_logentry' => 'Pro "[[$1]]"',
1408 - 'tog-show_task_comments' => 'Inserer le pagina de commentos super le carga.',
 1407+ 'tasks-pref-showtaskcomments' => 'Inserer le pagina de commentos super le carga.',
14091408 );
14101409
14111410 /** Italian (Italiano)
@@ -1479,7 +1478,7 @@
14801479 'tasks_logpage' => 'Registro attività',
14811480 'tasks_logpagetext' => 'Registro delle modifiche alle attività',
14821481 'tasks_logentry' => 'Per "[[$1]]"',
1483 - 'tog-show_task_comments' => "Inclusione della pagina dei commenti dell'attività",
 1482+ 'tasks-pref-showtaskcomments' => "Inclusione della pagina dei commenti dell'attività",
14841483 );
14851484
14861485 /** Japanese (日本語)
@@ -1554,7 +1553,7 @@
15551554 'tasks_logpage' => '課題記録',
15561555 'tasks_logpagetext' => 'これは各課題に対する変更の記録です',
15571556 'tasks_logentry' => '「[[$1]]」関連',
1558 - 'tog-show_task_comments' => '課題へのコメント用ページをトランスクルードする。',
 1557+ 'tasks-pref-showtaskcomments' => '課題へのコメント用ページをトランスクルードする。',
15591558 );
15601559
15611560 /** Javanese (Basa Jawa)
@@ -1758,7 +1757,7 @@
17591758 'tasks_logpage' => 'Logbooch met de Änderunge aan Aufjabe',
17601759 'tasks_logpagetext' => 'Dat Logbooch hee zeich Änderunge aan Aufjabe',
17611760 'tasks_logentry' => 'för „[[$1]]“',
1762 - 'tog-show_task_comments' => 'Dä Aufjab ier Klaafsigg he met aanzeije.',
 1761+ 'tasks-pref-showtaskcomments' => 'Dä Aufjab ier Klaafsigg he met aanzeije.',
17631762 );
17641763
17651764 /** Luxembourgish (Lëtzebuergesch)
@@ -1910,7 +1909,7 @@
19111910 'tasks_logpage' => 'Takenlogboek',
19121911 'tasks_logpagetext' => 'Hieronder staan alle wijzigingen aan taken',
19131912 'tasks_logentry' => 'Voor "[[$1]]"',
1914 - 'tog-show_task_comments' => 'Opmerkingenpagina voor taak transcluderen.',
 1913+ 'tasks-pref-showtaskcomments' => 'Opmerkingenpagina voor taak transcluderen.',
19151914 );
19161915
19171916 /** Norwegian Nynorsk (‪Norsk (nynorsk)‬)
@@ -1985,7 +1984,7 @@
19861985 'tasks_logpage' => 'Oppgåvelogg',
19871986 'tasks_logpagetext' => 'Dette er ein logg over endringar i oppgåver.',
19881987 'tasks_logentry' => 'For "[[$1]]"',
1989 - 'tog-show_task_comments' => 'Inkluder kommentarsida for oppgåver.',
 1988+ 'tasks-pref-showtaskcomments' => 'Inkluder kommentarsida for oppgåver.',
19901989 );
19911990
19921991 /** Occitan (Occitan)
@@ -2059,7 +2058,7 @@
20602059 'tasks_logpage' => 'Istoric dels prètzfaches',
20612060 'tasks_logpagetext' => 'Aquò es un istoric dels cambiaments dins los prètzfaches',
20622061 'tasks_logentry' => 'Per « [[$1]] »',
2063 - 'tog-show_task_comments' => 'Veire la pagina de comentaris a prepaus dels prètzfaches.',
 2062+ 'tasks-pref-showtaskcomments' => 'Veire la pagina de comentaris a prepaus dels prètzfaches.',
20642063 );
20652064
20662065 /** Ossetic (Иронау)
@@ -2151,7 +2150,7 @@
21522151 'tasks_logpage' => 'Rejestr zadań',
21532152 'tasks_logpagetext' => 'To jest rejestr zmian dotyczących zadań',
21542153 'tasks_logentry' => 'Dla „[[$1]]“',
2155 - 'tog-show_task_comments' => 'Wklej stronę dyskusji zadania.',
 2154+ 'tasks-pref-showtaskcomments' => 'Wklej stronę dyskusji zadania.',
21562155 );
21572156
21582157 /** Pashto (پښتو)
@@ -2242,7 +2241,7 @@
22432242 'tasks_logpage' => 'Registo de tarefas',
22442243 'tasks_logpagetext' => 'Este é um registo de alterações às tarefas',
22452244 'tasks_logentry' => 'Para "[[$1]]"',
2246 - 'tog-show_task_comments' => 'Transcluir página de comentários da tarefa',
 2245+ 'tasks-pref-showtaskcomments' => 'Transcluir página de comentários da tarefa',
22472246 );
22482247
22492248 /** Brazilian Portuguese (Português do Brasil)
@@ -2316,7 +2315,7 @@
23172316 'tasks_logpage' => 'Registro de tarefas',
23182317 'tasks_logpagetext' => 'Este é um registro de alterações às tarefas',
23192318 'tasks_logentry' => 'Para "[[$1]]"',
2320 - 'tog-show_task_comments' => 'Transcluir página de comentários da tarefa',
 2319+ 'tasks-pref-showtaskcomments' => 'Transcluir página de comentários da tarefa',
23212320 );
23222321
23232322 /** Romanian (Română)
@@ -2439,7 +2438,7 @@
24402439 'tasks_logpage' => 'Журнал задач',
24412440 'tasks_logpagetext' => 'Это журнал изменения задач',
24422441 'tasks_logentry' => 'Для «[[$1]]»',
2443 - 'tog-show_task_comments' => 'Включить страницу примечаний задачи.',
 2442+ 'tasks-pref-showtaskcomments' => 'Включить страницу примечаний задачи.',
24442443 );
24452444
24462445 /** Serbo-Croatian (Srpskohrvatski / Српскохрватски)
@@ -2521,7 +2520,7 @@
25222521 'tasks_logpage' => 'Záznam úloh',
25232522 'tasks_logpagetext' => 'Toto je záznam zmien v úlohách',
25242523 'tasks_logentry' => 'Pre "[[$1]]"',
2525 - 'tog-show_task_comments' => 'Transklúzia diskusnej stránky úlohy.',
 2524+ 'tasks-pref-showtaskcomments' => 'Transklúzia diskusnej stránky úlohy.',
25262525 );
25272526
25282527 /** Seeltersk (Seeltersk)
@@ -2596,7 +2595,7 @@
25972596 'tasks_logpage' => 'Apgoawen-Logbouk',
25982597 'tasks_logpagetext' => 'Dit Logbouk protokolliert Annerengen an Apgoawen.',
25992598 'tasks_logentry' => 'foar „[[$1]]“',
2600 - 'tog-show_task_comments' => 'Apgoawen-Diskussionssiede ienbiende.',
 2599+ 'tasks-pref-showtaskcomments' => 'Apgoawen-Diskussionssiede ienbiende.',
26012600 );
26022601
26032602 /** Swedish (Svenska)
@@ -2758,7 +2757,7 @@
27592758 'tasks_logpage' => 'Talaan ng mga gawain',
27602759 'tasks_logpagetext' => 'Isa itong talaan ng mga pagbabago sa mga gawain',
27612760 'tasks_logentry' => 'Para kay "[[$1]]"',
2762 - 'tog-show_task_comments' => 'Ilipat-sama ang pahina ng mga puna/kumentong panggawain.',
 2761+ 'tasks-pref-showtaskcomments' => 'Ilipat-sama ang pahina ng mga puna/kumentong panggawain.',
27632762 );
27642763
27652764 /** Turkish (Türkçe)
Index: trunk/extensions/Tasks/Tasks.php
@@ -1,4 +1,5 @@
22 <?php
 3+// FIXME: needs to be split in different files (Special page, possibly others like hooks).
34 /*
45 To activate, put something like this in your LocalSettings.php:
56 define( 'TASKS_CSS' , 'http://yourhost.com/name/wiki/extensions/Tasks/tasks.css' );
@@ -32,12 +33,13 @@
3334
3435
3536 Known bugs:
36 -* sidebar task list for Monobook only?
 37+* FIXME: sidebar task list for Monobook only?
3738
3839 */
3940
4041 if( !defined( 'MEDIAWIKI' ) ) die();
4142
 43+// FIXME: use lazy loading
4244 require_once ( "categoryfinder.php" ) ;
4345
4446 /** Default path to the stylesheet */
@@ -65,9 +67,7 @@
6668 $wgTaskExtensionTasksCache = array () ;
6769 $wgTaskExtensionTasksCachedTitle = '' ;
6870
69 -
7071 # Integrating into the MediaWiki environment
71 -
7272 $wgExtensionCredits['Tasks'][] = array(
7373 'name' => 'Tasks',
7474 'description' => 'An extension to manage tasks.',
@@ -90,6 +90,7 @@
9191 $wgHooks['ArticleViewHeader'][] = 'wfTaskExtensionHeaderHook';
9292 $wgHooks['EditPage::showEditForm:initial'][] = 'wfTaskExtensionEditFormInitialHook';
9393 $wgHooks['ParserTestTables'][] = 'wfTasksTestTables';
 94+$wgHooks['GetPreferences'][] = 'wfTasksOnGetPreferences';
9495
9596 # BEGIN logging functions
9697 $wgHooks['LogPageValidTypes'][] = 'wfTasksAddLogType';
@@ -120,24 +121,6 @@
121122 }
122123 # END logging functions
123124
124 -
125 -#_______________________________________________________________________________
126 -
127 -/**
128 -* Text adding function
129 -*/
130 -function wfTasksAddCache() { # Checked for HTML and MySQL insertion attacks
131 - global $wgTasksAddCache , $wgUserTogglesEn, $wgDefaultUserOptions;
132 - if( $wgTasksAddCache ) {
133 - return;
134 - }
135 - $wgTasksAddCache = true;
136 - $wgUserTogglesEn[] = 'show_task_comments' ;
137 -
138 - wfLoadExtensionMessages('Tasks');
139 -}
140 -
141 -
142125 #___________________________________________________________________
143126 # Hook functions
144127
@@ -175,6 +158,7 @@
176159 }
177160
178161 wfTasksAddCache();
 162+ wfLoadExtensionMessages('Tasks');
179163 $st = new SpecialTasks();
180164 $task = '';
181165 $page_title = $st->get_title_from_task( $taskid, $task );
@@ -214,6 +198,7 @@
215199 }
216200
217201 wfTasksAddCache();
 202+ wfLoadExtensionMessages('Tasks');
218203 $st = new SpecialTasks();
219204 $tasks = $st->get_open_task_list( $wgTitle, true );
220205 if( count( $tasks ) == 0 ) {
@@ -279,6 +264,7 @@
280265 }
281266
282267 wfTasksAddCache();
 268+ wfLoadExtensionMessages('Tasks');
283269 $st = new SpecialTasks;
284270 $tasks = $st->get_open_task_list( $wgTitle, true );
285271 if( count( $tasks ) == 0 ) {
@@ -326,6 +312,7 @@
327313 }
328314
329315 wfTasksAddCache();
 316+ wfLoadExtensionMessages('Tasks');
330317
331318 $st = new SpecialTasks;
332319 $st->rename_tasks_page( $old_title, $new_title );
@@ -339,6 +326,7 @@
340327 function wfTasksExtensionArticleDeleteComplete( &$article, &$user, $reason ) { # Checked for HTML and MySQL insertion attacks
341328 # return false ; # Uncomment this line to prevent deletion of tasks upon deletion of article
342329 wfTasksAddCache();
 330+ wfLoadExtensionMessages('Tasks');
343331 $t = $article->getTitle();
344332 if( $t->isTalkPage() ) {
345333 # No tasks for talk pages, no need to bother the database...
@@ -366,6 +354,7 @@
367355 function wfTasksExtensionArticleSaveComplete( &$article, &$user, $text, $summary, $isminor, $watchthis, $something ) { # Checked for HTML and MySQL insertion attacks
368356 global $wgUser;
369357 wfTasksAddCache();
 358+ wfLoadExtensionMessages('Tasks');
370359 $t = $article->getTitle();
371360 if( $t->isTalkPage() ) {
372361 # No tasks for talk pages, no need to bother the database...
@@ -437,6 +426,7 @@
438427 }
439428
440429 wfTasksAddCache();
 430+ wfLoadExtensionMessages('Tasks');
441431 $content_actions['tasks'] = array(
442432 'class' => ($action == 'tasks') ? 'selected' : false,
443433 'text' => wfMsgHTML('tasks_tab'),
@@ -455,6 +445,7 @@
456446 }
457447
458448 wfTasksAddCache();
 449+ wfLoadExtensionMessages('Tasks');
459450
460451 $t = new SpecialTasks;
461452 $t->page_management( $article->getTitle() );
@@ -470,6 +461,7 @@
471462 function wfTasksExtension() { # Checked for HTML and MySQL insertion attacks
472463 global $IP;
473464 wfTasksAddCache();
 465+ wfLoadExtensionMessages('Tasks');
474466
475467 require_once $IP.'/includes/SpecialPage.php';
476468
@@ -543,6 +535,7 @@
544536 */
545537 function update_types() { # Checked for HTML and MySQL insertion attacks
546538 wfTasksAddCache();
 539+ wfLoadExtensionMessages('Tasks');
547540
548541 # task type numeric key, text key, localized text
549542 $this->task_types = array();
@@ -1576,5 +1569,16 @@
15771570 return true;
15781571 }
15791572
 1573+/**
 1574+ * Hook for user preferences
 1575+ */
 1576+function wfTasksOnGetPreferences( $user, &$preferences ) {
 1577+ $preferences['show_task_comments'] =
 1578+ array(
 1579+ 'type' => 'toggle',
 1580+ 'section' => 'misc',
 1581+ 'label-message' => 'tasks-pref-showtaskcomments',
 1582+ );
15801583
1581 -?>
 1584+ return true;
 1585+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r67709Partial revert of possibly relevant part of wfTasksAddCache() back, as point...siebrand12:15, 9 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49790Branch merge of preferences work branch. Includes fixes for several bugs. WAR...werdna01:31, 24 April 2009

Comments

#Comment by Platonides (talk | contribs)   14:32, 8 June 2010

You removed wfTasksAddCache function, but it's still called 10 times. Any intent to use this extension will produce a fatal error.

#Comment by Siebrand (talk | contribs)   12:16, 9 June 2010

Setting to new because of r67709

Status & tagging log