r49905 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49904‎ | r49905 | r49906 >
Date:14:51, 26 April 2009
Author:philip
Status:ok
Tags:
Comment:
Follow up on r49790. Fixed a bug on variant select.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -168,7 +168,8 @@
169169
170170 $options = array();
171171 foreach( $variantArray as $code => $name ) {
172 - $options[$code] = "$code - $name";
 172+ $display = "$code - $name";
 173+ $options[$display] = $code;
173174 }
174175
175176 if(count($variantArray) > 1) {
@@ -182,7 +183,7 @@
183184 }
184185 }
185186
186 - if(count($variantArray) > 1 && !$wgDisableLangConversion && !$wgDisableTitleConversion) {
 187+ if( count($variantArray) > 1 && !$wgDisableLangConversion && !$wgDisableTitleConversion ) {
187188 $defaultPreferences['noconvertlink'] =
188189 array(
189190 'type' => 'toggle',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49790Branch merge of preferences work branch. Includes fixes for several bugs. WAR...werdna01:31, 24 April 2009

Status & tagging log