r20162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r20161‎ | r20162 | r20163 >
Date:09:48, 6 March 2007
Author:aaron
Status:old
Tags:
Comment:
*Add edittalk right to defaultsettings for convenience
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -324,7 +324,7 @@
325325 wfProfileOut( $fname );
326326 return;
327327 }
328 - if ( !$wgUser->isAllowed('edit') ) {
 328+ if ( (!$this->mTitle->isTalkPage() && !$wgUser->isAllowed('edit')) || ($this->mTitle->isTalkPage() && !$wgUser->isAllowed('edittalk')) ) {
329329 if ( $wgUser->isAnon() ) {
330330 wfDebug( "$fname: user must log in\n" );
331331 $this->userNotLoggedInPage();
Index: trunk/phase3/includes/DefaultSettings.php
@@ -959,6 +959,7 @@
960960 $wgGroupPermissions['*' ]['createaccount'] = true;
961961 $wgGroupPermissions['*' ]['read'] = true;
962962 $wgGroupPermissions['*' ]['edit'] = true;
 963+$wgGroupPermissions['*' ]['edittalk'] = true;
963964 $wgGroupPermissions['*' ]['createpage'] = true;
964965 $wgGroupPermissions['*' ]['createtalk'] = true;
965966
@@ -966,6 +967,7 @@
967968 $wgGroupPermissions['user' ]['move'] = true;
968969 $wgGroupPermissions['user' ]['read'] = true;
969970 $wgGroupPermissions['user' ]['edit'] = true;
 971+$wgGroupPermissions['user' ]['edittalk'] = true;
970972 $wgGroupPermissions['user' ]['createpage'] = true;
971973 $wgGroupPermissions['user' ]['createtalk'] = true;
972974 $wgGroupPermissions['user' ]['upload'] = true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r20169Revert r20162; changes behavior of sites that restrict editing, potentially...brion14:21, 6 March 2007