r20169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r20168‎ | r20169 | r20170 >
Date:14:21, 6 March 2007
Author:brion
Status:old
Tags:
Comment:
Revert r20162; changes behavior of sites that restrict editing, potentially
unsafely (for instance if raw HTML is enabled), without even a warning.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -324,7 +324,7 @@
325325 wfProfileOut( $fname );
326326 return;
327327 }
328 - if ( (!$this->mTitle->isTalkPage() && !$wgUser->isAllowed('edit')) || ($this->mTitle->isTalkPage() && !$wgUser->isAllowed('edittalk')) ) {
 328+ if ( !$wgUser->isAllowed('edit') ) {
329329 if ( $wgUser->isAnon() ) {
330330 wfDebug( "$fname: user must log in\n" );
331331 $this->userNotLoggedInPage();
Index: trunk/phase3/includes/DefaultSettings.php
@@ -959,7 +959,6 @@
960960 $wgGroupPermissions['*' ]['createaccount'] = true;
961961 $wgGroupPermissions['*' ]['read'] = true;
962962 $wgGroupPermissions['*' ]['edit'] = true;
963 -$wgGroupPermissions['*' ]['edittalk'] = true;
964963 $wgGroupPermissions['*' ]['createpage'] = true;
965964 $wgGroupPermissions['*' ]['createtalk'] = true;
966965
@@ -967,7 +966,6 @@
968967 $wgGroupPermissions['user' ]['move'] = true;
969968 $wgGroupPermissions['user' ]['read'] = true;
970969 $wgGroupPermissions['user' ]['edit'] = true;
971 -$wgGroupPermissions['user' ]['edittalk'] = true;
972970 $wgGroupPermissions['user' ]['createpage'] = true;
973971 $wgGroupPermissions['user' ]['createtalk'] = true;
974972 $wgGroupPermissions['user' ]['upload'] = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r20162*Add edittalk right to defaultsettings for convenienceaaron09:48, 6 March 2007