r114101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114100‎ | r114101 | r114102 >
Date:16:27, 18 March 2012
Author:jeroendedauw
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
follow up to r114081: qqq, and to r114082: match rename
Modified paths:
  • /trunk/phase3/includes/specials/SpecialCachedPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialCachedPage.php
@@ -94,7 +94,7 @@
9595 if ( $this->cacheExpiry < 1000000000 ) {
9696 $message = $this->msg(
9797 'cachedspecial-viewing-cached-ttl',
98 - $this->getLanguage()->duration( $this->cacheExpiry )
 98+ $this->getLanguage()->formatDuration( $this->cacheExpiry )
9999 )->escaped();
100100 }
101101 else {
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -4640,5 +4640,7 @@
46414641 * $1 is an unknown warning.',
46424642 'api-error-uploaddisabled' => 'API error message that can be used for client side localisation of API errors.',
46434643 'api-error-verification-error' => 'The word "extension" refers to the part behind the last dot in a file name, that by convention gives a hint about the kind of data format which a files contents are in.',
4644 -
 4644+'cachedspecial-viewing-cached-ttl' => 'Message notifying they are watching a cached page. $1 is a duration (ie "1 hour and 30 minutes")',
 4645+'cachedspecial-viewing-cached-ts' => 'Message notifying they are watching a cached page.',
 4646+'cachedspecial-refresh-now' => 'Link text pointing to the most recent version of the page.',
46454647 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114326Revert r114067, r114071, r114075, r114079, r114081, r114082, r114084, r114086......catrope23:03, 20 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114081adding special page with scaffolding for caching chunks of HTMLjeroendedauw22:26, 17 March 2012
r114082Followup r114067 rename to formatDuration to match other methodsreedy22:26, 17 March 2012

Comments

#Comment by Krinkle (talk | contribs)   14:58, 19 March 2012
+'cachedspecial-viewing-cached-ts' => 'Message notifying they are watching a cached page.',
 

Just FYI: Better use "viewing" instead of "watching" to stick with the general terminology used in MediaWiki, as well as to avoid confusion with WatchAction (after adding a page to your watchlist it may also say "You are now watching ..."). Especially for non-native speakers of English.

(fixed at translatewiki.net)

Status & tagging log