r114086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114085‎ | r114086 | r114087 >
Date:22:47, 17 March 2012
Author:reedy
Status:reverted
Tags:gerritmigration 
Comment:
Noralise a few of the magic numbers used in r114084
Modified paths:
  • /trunk/phase3/tests/phpunit/languages/LanguageTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/languages/LanguageTest.php
——@@ -705,7 +705,7 @@
706706 "2 days",
707707 ),
708708 array(
709 - 365.25 * 86400,
 709+ 365.25 * 86400, // 365.25 * 86400 = 31557600
710710 "1 year",
711711 ),
712712 array(
——@@ -717,7 +717,7 @@
718718 "1 decade",
719719 ),
720720 array(
721 - 2 * 10 * 31557600,
 721+ 20 * 31557600,
722722 "2 decades",
723723 ),
724724 array(
——@@ -733,7 +733,7 @@
734734 "1 millennium",
735735 ),
736736 array(
737 - 2 * 1000 * 31557600,
 737+ 2000 * 31557600,
738738 "2 millennia",
739739 ),
740740 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114326Revert r114067, r114071, r114075, r114079, r114081, r114082, r114084, r114086......catrope23:03, 20 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114084Unit tests for r114067reedy22:39, 17 March 2012

Status & tagging log