r114102 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114101‎ | r114102 | r114103 >
Date:17:39, 18 March 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r114082, match rename
Modified paths:
  • /trunk/extensions/EducationProgram/compat/SpecialCachedPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/compat/SpecialCachedPage.php
@@ -56,8 +56,6 @@
5757 * @param string|null $subPage
5858 */
5959 public function execute( $subPage ) {
60 - //parent::execute( $subPage );
61 -
6260 if ( $this->getRequest()->getText( 'action' ) === 'purge' ) {
6361 $this->hasCached = false;
6462 }
@@ -110,7 +108,7 @@
111109
112110 /**
113111 * Returns a message with the time to live of the cache.
114 - * Takes care of compatibility with MW < 1.20, in which Language::duration was introduced.
 112+ * Takes care of compatibility with MW < 1.20, in which Language::formatDuration was introduced.
115113 *
116114 * @since 0.1
117115 *
@@ -120,8 +118,8 @@
121119 * @return string
122120 */
123121 protected function getDurationText( $seconds, array $chosenIntervals = array( 'years', 'days', 'hours', 'minutes', 'seconds' ) ) {
124 - if ( method_exists( $this->getLanguage(), 'duration' ) ) {
125 - return $this->getLanguage()->duration( $seconds, $chosenIntervals );
 122+ if ( method_exists( $this->getLanguage(), 'formatDuration' ) ) {
 123+ return $this->getLanguage()->formatDuration( $seconds, $chosenIntervals );
126124 }
127125 else {
128126 $intervals = array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114082Followup r114067 rename to formatDuration to match other methodsreedy22:26, 17 March 2012

Status & tagging log