r114082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114081‎ | r114082 | r114083 >
Date:22:26, 17 March 2012
Author:reedy
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
Followup r114067 rename to formatDuration to match other methods
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -1919,7 +1919,7 @@
19201920 *
19211921 * @return string
19221922 */
1923 - public function duration( $seconds, array $chosenIntervals = array( 'millennia', 'centuries', 'decades', 'years', 'days', 'hours', 'minutes', 'seconds' ) ) {
 1923+ public function formatDuration( $seconds, array $chosenIntervals = array( 'millennia', 'centuries', 'decades', 'years', 'days', 'hours', 'minutes', 'seconds' ) ) {
19241924 $intervals = array(
19251925 'millennia' => 1000 * 31557600,
19261926 'centuries' => 100 * 31557600,

Follow-up revisions

RevisionCommit summaryAuthorDate
r114101follow up to r114081: qqq, and to r114082: match renamejeroendedauw16:27, 18 March 2012
r114102follow up to r114082, match renamejeroendedauw17:39, 18 March 2012
r114326Revert r114067, r114071, r114075, r114079, r114081, r114082, r114084, r114086......catrope23:03, 20 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114067adding a duration function to language that converts seconds to textjeroendedauw20:58, 17 March 2012

Comments

#Comment by Jeroen De Dauw (talk | contribs)   22:27, 17 March 2012

??? what other methods? The most similar methods are "time" and "date", which have the same format as this one.

Status & tagging log