r113782 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113781‎ | r113782 | r113783 >
Date:23:09, 13 March 2012
Author:amire80
Status:ok
Tags:i18ndeploy, i18nreview 
Comment:
Bug 35034 - moved autocomment-prefix between the prefix and the arrow. Follow up to r109086.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -8483,6 +8483,16 @@
84848484 !!end
84858485
84868486 !! test
 8487+Edit comment with section link and text before it (non-local, eg in history list)
 8488+!! options
 8489+comment title=[[Main Page]]
 8490+!! input
 8491+pre-comment text /* External links */ removed bogus entries
 8492+!! result
 8493+pre-comment text - <a href="https://www.mediawiki.org/wiki/Main_Page#External_links" title="Main Page">→</a>‎<span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span>
 8494+!!end
 8495+
 8496+!! test
84878497 Edit comment with section link (local, eg in diff view)
84888498 !! options
84898499 comment local title=[[Main Page]]
Index: trunk/phase3/includes/Linker.php
@@ -1193,7 +1193,7 @@
11941194 }
11951195 if ( $pre ) {
11961196 # written summary $presep autocomment (summary /* section */)
1197 - $auto = wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) ) . $auto;
 1197+ $pre .= wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) );
11981198 }
11991199 if ( $post ) {
12001200 # autocomment $postsep written summary (/* section */ summary)

Follow-up revisions

RevisionCommit summaryAuthorDate
r1141601.19wmf1 MFT r113910 r113782nikerabbit18:09, 19 March 2012
r114374MFT r113412, r113441, r113601, r113617, r113782reedy16:57, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109086Follow up to r105855 - now with updated phpunit tests.amire8000:17, 17 January 2012

Status & tagging log