r109086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109085‎ | r109086 | r109087 >
Date:00:17, 17 January 2012
Author:amire80
Status:ok (Comments)
Tags:core, i18nreview 
Comment:
Follow up to r105855 - now with updated phpunit tests.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -8479,7 +8479,7 @@
84808480 !! input
84818481 /* External links */ removed bogus entries
84828482 !! result
8483 -<span class="autocomment"><a href="https://www.mediawiki.org/wiki/Main_Page#External_links" title="Main Page">→</a>External links: </span> removed bogus entries
 8483+<a href="https://www.mediawiki.org/wiki/Main_Page#External_links" title="Main Page">→</a>‎<span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span>
84848484 !!end
84858485
84868486 !! test
@@ -8489,7 +8489,7 @@
84908490 !! input
84918491 /* External links */ removed bogus entries
84928492 !! result
8493 -<span class="autocomment"><a href="#External_links">→</a>External links: </span> removed bogus entries
 8493+<a href="#External_links">→</a>‎<span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span>
84948494 !!end
84958495
84968496 !! test
@@ -8576,7 +8576,7 @@
85778577 !!input
85788578 /* __hello__world__ */
85798579 !! result
8580 -<span class="autocomment"><a href="https://www.mediawiki.org/wiki/Main_Page#hello_world" title="Main Page">→</a>__hello__world__</span>
 8580+<a href="https://www.mediawiki.org/wiki/Main_Page#hello_world" title="Main Page">→</a>‎<span dir="auto"><span class="autocomment">__hello__world__</span></span>
85818581 !! end
85828582
85838583 !! test
Index: trunk/phase3/includes/Linker.php
@@ -1178,7 +1178,6 @@
11791179 $link = '';
11801180 }
11811181 }
1182 - $auto = "$link$auto";
11831182 if ( $pre ) {
11841183 # written summary $presep autocomment (summary /* section */)
11851184 $auto = wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) ) . $auto;
@@ -1188,7 +1187,7 @@
11891188 $auto .= wfMsgExt( 'colon-separator', array( 'escapenoentities', 'content' ) );
11901189 }
11911190 $auto = '<span class="autocomment">' . $auto . '</span>';
1192 - $comment = $pre . $auto . $post;
 1191+ $comment = $pre . $link . $wgLang->getDirMark() . '<span dir="auto">' . $auto . $post . '</span>';
11931192 return $comment;
11941193 }
11951194

Follow-up revisions

RevisionCommit summaryAuthorDate
r113782Bug 35034 - moved autocomment-prefix between the prefix and the arrow. Follow...amire8023:09, 13 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105855Replaced the core message 'sectionlink' with getArrow, which is cleaner and d...amire8006:40, 12 December 2011

Comments

#Comment by Umherirrender (talk | contribs)   17:46, 7 March 2012

Please have a look at bug 35034. Thanks.

Status & tagging log