r114160 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114159‎ | r114160 | r114161 >
Date:18:09, 19 March 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
1.19wmf1 MFT r113910 r113782
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/WebFonts/resources/ext.webfonts.fontlist.js (modified) (history)
  • /branches/wmf/1.19wmf1/includes/Linker.php (modified) (history)
  • /branches/wmf/1.19wmf1/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/WebFonts/resources/ext.webfonts.fontlist.js
@@ -388,7 +388,7 @@
389389 ttf: "Xsux/Akkadian.ttf",
390390 woff: "Xsux/Akkadian.woff",
391391 version: "2.56"
392 - },
 392+ }
393393 /*
394394 "Hapax Berbère": {
395395 eot: "Tfng/hapaxber.eot",
@@ -442,7 +442,7 @@
443443 ta: [ "Lohit Tamil", "Thendral", "Thenee" ],
444444 tcy: [ "Lohit Kannada", "Kedage" ],
445445 te: [ "Lohit Telugu", "Pothana2000", "Vemana2000" ],
446 - ti: [ "AbyssinicaSIL" ],
 446+ ti: [ "AbyssinicaSIL" ]
447447 // tmh: [ "Hapax Berbère" ],
448448 // tzm: [ "Hapax Berbère" ]
449449 }
Index: branches/wmf/1.19wmf1/tests/parser/parserTests.txt
@@ -8483,6 +8483,16 @@
84848484 !!end
84858485
84868486 !! test
 8487+Edit comment with section link and text before it (non-local, eg in history list)
 8488+!! options
 8489+comment title=[[Main Page]]
 8490+!! input
 8491+pre-comment text /* External links */ removed bogus entries
 8492+!! result
 8493+pre-comment text - <a href="https://www.mediawiki.org/wiki/Main_Page#External_links" title="Main Page">→</a>‎<span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span>
 8494+!!end
 8495+
 8496+!! test
84878497 Edit comment with section link (local, eg in diff view)
84888498 !! options
84898499 comment local title=[[Main Page]]
Index: branches/wmf/1.19wmf1/includes/Linker.php
@@ -1182,7 +1182,7 @@
11831183 }
11841184 if ( $pre ) {
11851185 # written summary $presep autocomment (summary /* section */)
1186 - $auto = wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) ) . $auto;
 1186+ $pre .= wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) );
11871187 }
11881188 if ( $post ) {
11891189 # autocomment $postsep written summary (/* section */ summary)
Property changes on: branches/wmf/1.19wmf1/includes/Linker.php
___________________________________________________________________
Modified: svn:mergeinfo
11901190 Merged /trunk/phase3/includes/Linker.php:r113782

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113782Bug 35034 - moved autocomment-prefix between the prefix and the arrow. Follow...amire8023:09, 13 March 2012
r113910Remove trailing commas, to avoid issues with some browsers.santhosh12:13, 15 March 2012

Status & tagging log