r113617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113616‎ | r113617 | r113618 >
Date:12:43, 12 March 2012
Author:kaldari
Status:ok
Tags:
Comment:
fix for bug 34696 - mw.loader.using shouldnt call callback more than once
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -611,11 +611,12 @@
612612 filter( 'ready', jobs[j].dependencies ),
613613 jobs[j].dependencies ) )
614614 {
615 - if ( $.isFunction( jobs[j].ready ) ) {
616 - jobs[j].ready();
617 - }
 615+ var callback = jobs[j].ready;
618616 jobs.splice( j, 1 );
619617 j -= 1;
 618+ if ( $.isFunction( callback ) ) {
 619+ callback();
 620+ }
620621 }
621622 }
622623 // Execute modules whose dependencies have just been met

Follow-up revisions

RevisionCommit summaryAuthorDate
r113935MFT r112918, r113214, r113394, r113415, r113617, r113710, r113727, r113737, r...reedy17:27, 15 March 2012
r114374MFT r113412, r113441, r113601, r113617, r113782reedy16:57, 21 March 2012

Status & tagging log