r113727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113726‎ | r113727 | r113728 >
Date:15:54, 13 March 2012
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 34887) Fix for r100138: make $3 and $4 parameters being substituted correctly in message "movepage-moved"
Modified paths:
  • /branches/REL1_19/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/REL1_19/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -16,6 +16,8 @@
1717 included page
1818 * (bug 35019) Edit summaries are no longer transformed in notification e-mails
1919 * (bug 35152) Help message for e-mail is shown again in user preferences
 20+* (bug 34887) $3 and $4 parameters are now substituted correctly in message
 21+ "movepage-moved"
2022
2123 === Configuration changes in 1.19 ===
2224 * Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -472,7 +472,8 @@
473473 $newText = $nt->getPrefixedText();
474474
475475 $msgName = $createRedirect ? 'movepage-moved-redirect' : 'movepage-moved-noredirect';
476 - $out->addHTML( wfMessage( 'movepage-moved' )->rawParams( $oldLink, $newLink, $oldText, $newText )->parseAsBlock() );
 476+ $out->addHTML( wfMessage( 'movepage-moved' )->rawParams( $oldLink,
 477+ $newLink )->params( $oldText, $newText )->parseAsBlock() );
477478 $out->addWikiMsg( $msgName );
478479
479480 # Now we move extra pages we've been asked to move: subpages and talk
Index: branches/REL1_19/phase3/RELEASE-NOTES-1.19
@@ -16,6 +16,8 @@
1717 included page
1818 * (bug 35019) Edit summaries are no longer transformed in notification e-mails
1919 * (bug 35152) Help message for e-mail is shown again in user preferences
 20+* (bug 34887) $3 and $4 parameters are now substituted correctly in message
 21+ "movepage-moved"
2022
2123 === Configuration changes in 1.19 ===
2224 * Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: branches/REL1_19/phase3/includes/specials/SpecialMovepage.php
@@ -471,7 +471,8 @@
472472 $newText = $nt->getPrefixedText();
473473
474474 $msgName = $createRedirect ? 'movepage-moved-redirect' : 'movepage-moved-noredirect';
475 - $out->addHTML( wfMessage( 'movepage-moved' )->rawParams( $oldLink, $newLink, $oldText, $newText )->parseAsBlock() );
 475+ $out->addHTML( wfMessage( 'movepage-moved' )->rawParams( $oldLink,
 476+ $newLink )->params( $oldText, $newText )->parseAsBlock() );
476477 $out->addWikiMsg( $msgName );
477478
478479 # Now we move extra pages we've been asked to move: subpages and talk

Follow-up revisions

RevisionCommit summaryAuthorDate
r113935MFT r112918, r113214, r113394, r113415, r113617, r113710, r113727, r113737, r...reedy17:27, 15 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100138* (bug 18823) "move succeeded" text displays bluelinks even when redirect was...raymond17:57, 18 October 2011

Comments

#Comment by Krinkle (talk | contribs)   03:40, 15 March 2012

This is a 1.19 regression, no need for release notes.

#Comment by Krinkle (talk | contribs)   03:40, 15 March 2012

Oh, 1.19beta is out?

Status & tagging log