r113816 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113815‎ | r113816 | r113817 >
Date:16:04, 14 March 2012
Author:ialex
Status:ok
Tags:
Comment:
* (bug 34841) Fix for r103502: don't show edit links when display old page versions
Modified paths:
  • /branches/REL1_19/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/REL1_19/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -18,6 +18,7 @@
1919 * (bug 35152) Help message for e-mail is shown again in user preferences
2020 * (bug 34887) $3 and $4 parameters are now substituted correctly in message
2121 "movepage-moved"
 22+* (bug 34841) Edit links are no longer displayed when display old page versions
2223
2324 === Configuration changes in 1.19 ===
2425 * Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: trunk/phase3/includes/Article.php
——@@ -455,7 +455,7 @@
456456 if ( $wgOut->isPrintable() ) {
457457 $parserOptions->setIsPrintable( true );
458458 $parserOptions->setEditSection( false );
459 - } elseif ( !$this->getTitle()->quickUserCan( 'edit' ) ) {
 459+ } elseif ( !$this->isCurrent() || !$this->getTitle()->quickUserCan( 'edit' ) ) {
460460 $parserOptions->setEditSection( false );
461461 }
462462
Index: branches/REL1_19/phase3/RELEASE-NOTES-1.19
——@@ -18,6 +18,7 @@
1919 * (bug 35152) Help message for e-mail is shown again in user preferences
2020 * (bug 34887) $3 and $4 parameters are now substituted correctly in message
2121 "movepage-moved"
 22+* (bug 34841) Edit links are no longer displayed when display old page versions
2223
2324 === Configuration changes in 1.19 ===
2425 * Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: branches/REL1_19/phase3/includes/Article.php
——@@ -451,7 +451,7 @@
452452 if ( $wgOut->isPrintable() ) {
453453 $parserOptions->setIsPrintable( true );
454454 $parserOptions->setEditSection( false );
455 - } elseif ( !$this->getTitle()->quickUserCan( 'edit' ) ) {
 455+ } elseif ( !$this->isCurrent() || !$this->getTitle()->quickUserCan( 'edit' ) ) {
456456 $parserOptions->setEditSection( false );
457457 }
458458

Follow-up revisions

RevisionCommit summaryAuthorDate
r113935MFT r112918, r113214, r113394, r113415, r113617, r113710, r113727, r113737, r...reedy17:27, 15 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103502* Added WikiPage::getParserOutput() and changed Article::getParserOutput() to...ialex20:21, 17 November 2011

Status & tagging log