r113099 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113098‎ | r113099 | r113100 >
Date:22:43, 5 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Special pages aren't a contextsource. Ping r100114, pass $this->getContext()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -804,7 +804,7 @@
805805 function resetLoginForm( $error ) {
806806 $this->getOutput()->addHTML( Xml::element('p', array( 'class' => 'error' ), $error ) );
807807 $reset = new SpecialChangePassword();
808 - $reset->setContext( $this );
 808+ $reset->setContext( $this->getContext() );
809809 $reset->execute( null );
810810 }
811811

Follow-up revisions

RevisionCommit summaryAuthorDate
r113157MFT r112563, r112566, r112838, r112872, r112873, r112988, r113001, r113024, r...reedy17:36, 6 March 2012
r113176MFT r113099reedy20:16, 6 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100114* Use local context instead of global variables...ialex14:08, 18 October 2011

Status & tagging log