r112383 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112382‎ | r112383 | r112384 >
Date:02:01, 25 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Fixed $headers check in streamFile() to use isset()
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/FileBackend.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/FileBackend.php
@@ -1262,7 +1262,7 @@
12631263 }
12641264
12651265 // Set output buffer and HTTP headers for stream
1266 - $extraHeaders = $params['headers'] ? $params['headers'] : array();
 1266+ $extraHeaders = isset( $params['headers'] ) ? $params['headers'] : array();
12671267 $res = StreamFile::prepareForStream( $params['src'], $info, $extraHeaders );
12681268 if ( $res == StreamFile::NOT_MODIFIED ) {
12691269 // do nothing; client cache is up to date

Follow-up revisions

RevisionCommit summaryAuthorDate
r112532MFT r112374, r112383, r112397, r112408, r112474reedy22:31, 27 February 2012
r113040MFT r111427, r112347, r112374, r112383, r112700, r112750, r112855reedy15:15, 5 March 2012

Status & tagging log